94659[BUGFIX] Allow ContentArea usage with `f:for` iteration
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Josua Vogel +1
- Mathias Brodala +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Josua Vogel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1720
-
Matthias Vogel uploaded patch set 1 07/02/26, 10:00
-
core-ci voted on patch set 1 V -1 07/02/26, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104226
-
Matthias Vogel updated the commit message in patch set 2
V -107/06/26, 07:16 -
Matthias Vogel marked it ready for review 07/06/26, 07:16
-
core-ci voted on patch set 2 V +1 07/06/26, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104384
-
Josua Vogel voted on patch set 2 CR +1 V +1 07/06/26, 08:57
-
Oliver Klee voted on patch set 2 CR +1 V +1 07/06/26, 09:40
-
Mathias Brodala voted on patch set 2 CR +1 V +1 07/10/26, 08:54
-
Simon Praetorius voted on patch set 2 CR +1 V +1 07/10/26, 08:55
-
Oli Bartsch commented on patch set 2 07/10/26, 09:43
-
Mathias Brodala commented on patch set 2 07/10/26, 09:48
ContentAreaTest.php:44ReplyA bit more verbose: PHPUnits assertCount() is rather lenient since it also iterates traversable objects to determine the count. This would already succeed even if Countable is not implemented. So yes, count($subject) is the way to go IMO. Even better would be a functional test which literally uses `f:for` with "iteration". in a Fluid template on a content area. That's the whole point of the change after all. -
Matthias Vogel uploaded patch set 3
CR +1V +107/13/26, 16:24 -
core-ci voted on patch set 3 V +1 07/13/26, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104721
-
Josua Vogel voted on patch set 3 CR +1 V +1 07/13/26, 16:49
-
Matthias Vogel commented on patch set 3 07/14/26, 06:45
ngeContentAreaTest.php:44Replychanged to `self::assertSame(2, $subject->count());` and added fluid `f:for` test case -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/14/26, 08:35
-
Mathias Brodala voted on patch set 3 CR +1 07/14/26, 09:35
-
Garvin Hicking voted on patch set 3 CR +1 V +1 07/14/26, 19:31
-
Oli Bartsch voted on patch set 3 CR +2 V +2 07/15/26, 12:54
-
Oli Bartsch merged patch set 4 07/15/26, 12:54
ContentAreaTest.php:44