94671[BUGFIX] Centralize focus handling in the backend wizard
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/page-wizard/steps/position-step.ts+5 −0
- Build/Sources/TypeScript/backend/tree/page-position-select.ts+25 −0
- Build/Sources/TypeScript/backend/wizard/wizard.ts4+97 −2
- Build/Sources/TypeScript/form/backend/form-wizard/steps/settings-step.ts+0 −10
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/steps/position-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-position-select.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/wizard.js+2 −2
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/steps/settings-step.js+1 −1
Review log 1318
-
Benjamin Kott uploaded patch set 1 07/03/26, 13:13
-
core-ci voted on patch set 1 V +1 07/03/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104287
-
Benjamin Kott uploaded patch set 2
V +107/03/26, 13:49 -
core-ci voted on patch set 2 V +1 07/03/26, 14:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104292
-
Benjamin Kott uploaded patch set 3 07/03/26, 14:30
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 3 V +1 07/03/26, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104302
-
Benjamin Kott uploaded patch set 4
V +107/07/26, 12:01 -
core-ci voted on patch set 4 V +1 07/07/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104461
-
Andreas Kienast commented on patch set 4 07/09/26, 10:05
wizard.ts:252I'd prefer to wrap this major chunk into a separate condition. It makes clear it needs `content` and thus allows to drop a lot of null-coalesce chaining. ```suggestion if (content) { if (content.contains(this.ownerDocument.activeElement)) { return true; } // Respect an explicit autofocus declared by the step. const explicit = content.querySelector<HTMLElement>('[autofocus]'); if (explicit) { explicit.focus(); return true; } const target = content.querySelector<HTMLElement>('input[type="radio"]:checked') ?? content.querySelector<HTMLElement>('input:not([type="hidden"]):not([type="radio"]):not([disabled]), select:not([disabled]), textarea:not([disabled])'); if (target) { // autofocus makes an opening modal <dialog> pick this over the close // button; focus() covers later step transitions. target.setAttribute('autofocus', ''); target.focus(); return true; } } ``` -
Benjamin Franzke commented on patch set 4 07/10/26, 07:05
wizard.ts:244I think this can be replaced by `content?.querySelector(':read-write')` -
Benjamin Kott uploaded patch set 5
V +107/10/26, 09:47 -
Benjamin Kott commented on patch set 5 07/10/26, 09:48
wizard.ts:252ReplyDone -
core-ci voted on patch set 5 V +1 07/10/26, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104599
-
Georg Ringer voted on patch set 5 CR +1 V +1 07/14/26, 21:12
-
Benjamin Franzke commented on patch set 5 07/16/26, 11:00
wizard.ts:244Replyfine by me as-is, as :read-write does not include select. -
Andreas Kienast voted on patch set 5 CR +1 V +1 07/17/26, 05:04
-
Benjamin Kott voted on patch set 5 CR +2 V +2 07/17/26, 07:50
-
Benjamin Kott merged patch set 6 07/17/26, 07:50