94672[BUGFIX] Show only metadata fields of the file type in file info
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+19 −6
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/Fixtures/ElementInformation/Files/image.svgnew+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/Fixtures/ElementInformation/Files/video.mp4new+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/Fixtures/ElementInformation/ElementInformationFiles.csvnew+8 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/Fixtures/ElementInformation/file-storages.yamlnew+9 −0
- typo3/sysext/backend/Tests/Functional/Controller/ContentElement/ElementInformationControllerTest.phpnew+84 −0
- typo3/sysext/core/Classes/Schema/VisibleSchemaFieldsCollector.php+10 −5
- typo3/sysext/core/Tests/Functional/Schema/VisibleSchemaFieldsCollectorTest.php+16 −2
Review log 913
-
Gianluigi Martino uploaded patch set 1 07/03/26, 13:17
-
core-ci voted on patch set 1 V +1 07/03/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104289
-
Gianluigi Martino updated the commit message in patch set 2
V +107/03/26, 13:31 -
core-ci voted on patch set 2 V +1 07/03/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104290
-
Riccardo De Contardi commented on patch set 2 07/03/26, 15:01
It works for images but... for non-image files (I tested with a pdf and an mp4 movie), the "plain numbers" "width" and "height" are shown instead, with... 0 as value. I can guess that this is the expected behavior, but I'm wondering how much sense there is in showing the width and height for non-image files...I guess they will always show 0...or not? -
Gianluigi Martino rebased onto patch set 3
V +111/13/26, 08:16 -
core-ci voted on patch set 3 V +1 11/13/26, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114286
-
Benni Mack uploaded patch set 4
V +111/13/26, 08:35 -
core-ci voted on patch set 4 V +1 11/13/26, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114289
-
Benni Mack voted on patch set 4 CR +1 V +1 11/13/26, 09:05
-
Georg Ringer voted on patch set 4 CR +1 V +1 11/13/26, 09:34
-
Benni Mack voted on patch set 4 CR +2 V +2 11/13/26, 09:40
-
Benni Mack merged patch set 5 11/13/26, 09:40