94684[SECURITY] Register MimeTypeValidator for file uploads at runtime
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+0 −17
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+15 −0
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php2+58 −0
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+9 −0
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/MultipleFileUploadTest.php+149 −0
- typo3/sysext/form/Tests/Functional/Mvc/Property/FileUploadMimeTypeValidatorRegistrationTest.phpnew+150 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/FileUploadTest.php+0 −35
Review log 2534
Show 69 earlier messages
-
Josua Vogel uploaded patch set 1 07/06/26, 11:18
-
Josua Vogel uploaded patch set 2 07/06/26, 11:21
-
Josua Vogel marked it work in progress 07/06/26, 11:31
-
core-ci voted on patch set 1 V -1 07/06/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104399
-
core-ci voted on patch set 2 V -1 07/06/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104400
-
Josua Vogel uploaded patch set 3
V -107/06/26, 11:54 -
Oliver Hader wrote 07/06/26, 11:54
Set private -
core-ci voted on patch set 3 V +1 07/06/26, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104402
-
Oliver Hader commented on patch set 3 07/08/26, 20:11
This would be a change for v14.3 as well, wouldn't it?
-
Garvin Hicking commented on patch set 3 07/08/26, 20:33
Reply
Yes. I've for now only glanced at this, but from code reading this looks sane. Since this kind or "publically leaked" do you think we can/should wrap this up for next tuesday's release, or is that unrealistic due to dialogue days and such? -
Oliver Hader updated the commit message in patch set 4
V +107/09/26, 16:21 -
Oliver Hader commented on patch set 4 07/09/26, 16:22
Reply
Next Tuesday would be great. And somehow we (or I) must find a way to make this work, even if there are other "event". -
core-ci voted on patch set 4 V +1 07/09/26, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104575
-
Oliver Hader commented on patch set 4 07/09/26, 16:32
``` Security-Bulletin: TYPO3-CORE-SA-2026-019 Security-References: CVE-2026-15305 ``` -
Oliver Hader commented on patch set 4 07/09/26, 17:38
There still is another flaw, since the validation logic was moved form the `UploadedFileReferenceConverter` to `\TYPO3\CMS\Form\Mvc\ProcessingRule::process`, it means that invalid files (e.g. `malicous.exe`) are persisted again and remain in the directory when the validation failed. Previously `\TYPO3\CMS\Form\Mvc\Property\TypeConverter\PseudoFile` is `UploadedFileReferenceConverter` handled that, without having the necessity to use a real persisted FAL file or file-reference object. -
Oliver Hader uploaded patch set 5
V +107/09/26, 18:49 -
core-ci voted on patch set 5 V +1 07/09/26, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104576
-
Garvin Hicking commented on patch set 5 07/09/26, 19:06
PropertyMappingConfiguration.php:95Nice. I played around with this today and was on with a very similar solution. Will test yours more in detail tomorrow. Sorry for not catching this initially for the feature, mea culpa. -
Oliver Hader commented on patch set 5 07/10/26, 14:29
This change is ready for review. -
Oliver Hader voted on patch set 5 CR +1 V +1 07/10/26, 14:29
-
Garvin Hicking uploaded patch set 6
CR +1V +107/10/26, 15:47 -
Garvin Hicking commented on patch set 6 CR +1 V +1 07/10/26, 15:51
PropertyMappingConfiguration.php:95ReplyI've spent too many hours today to do a lot of manual testing. I created form variants for: mimeupload-single: One step, one single file upload, one single image upload mimeupload-single-extravalidate: As above, but each upload field has a filesize validator on top mimeupload-single-multipage: As above, but a second page (to ensure not forwarding to the next page) mimeupload-multi, mimeupload-multi-extravalidate, mimeupload-multi-multipage: As above, but with "multiple" upload fields mimeupload-all: As above, but with both single AND multiple file uploads variants on the same page In each form I then uploaded: - all valid files - modified the DOM to remove `accept` and upload invalid files - upload `.php` files - in multiple upload fields, combined valid and invalid uploads - upload files valid and invalid, matching and not matching the filesize validators I think I saw the file upload picker more than 100 times today. It all seemed to work without regressions and without allowing to persist the denied files, plus emitting proper validation failures. -
core-ci voted on patch set 6 V +1 07/10/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104637
-
Oliver Hader commented on patch set 6 07/10/26, 19:40
Reply
Done -
Torben Hansen voted on patch set 3 CR +1 V +1 07/11/26, 10:33
-
Josua Vogel voted on patch set 6 CR +1 V +1 07/11/26, 13:44
-
Oliver Hader rebased onto patch set 7
CR +1V +107/14/26, 08:24 -
Oliver Hader commented on patch set 7 07/14/26, 08:25
Reply
Done -
core-ci voted on patch set 7 V -1 07/14/26, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104743
-
core-ci commented on patch set 7 07/14/26, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104743
-
core-ci voted on patch set 7 V +1 07/14/26, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104743
-
Oliver Hader wrote 07/14/26, 12:05
Unset private -
Oliver Hader voted on patch set 7 CR +2 V +2 07/14/26, 12:08
-
Oliver Hader merged patch set 8 07/14/26, 12:08