94686[BUGFIX] Fix broken module link in breadcrumb
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Kott +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/backend/Classes/Breadcrumb/RecordBreadcrumbProvider.php4+46 −15
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+49 −2
- typo3/sysext/backend/Classes/Controller/SiteSettingsController.php+22 −1
- typo3/sysext/backend/Tests/Functional/Controller/SiteBreadcrumbTest.phpnew+173 −0
- typo3/sysext/backend/Tests/Functional/Template/Components/BreadcrumbTest.php+131 −49
Review log 1418
-
Josua Vogel uploaded patch set 1 07/06/26, 18:06
-
core-ci voted on patch set 1 V +1 07/06/26, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104421
-
Benjamin Franzke voted on patch set 1 CR +1 V +1 07/08/26, 10:04
-
Benjamin Franzke commented on patch set 1 07/08/26, 12:39
-
Benjamin Franzke commented on patch set 1 CR 0 V 0 07/08/26, 13:06
Hm, this fixes the bug only implicitly, because it assumes that the route can not be "kept", when the module changes, but we have no understanding, why/when we need to use another route-identifier in general. That also applies to modules Other modules, where sub-modules are used are therefore still broken. I guess that means we need another fix. Example: Editing a site via `/module/site/configuration/edit?site=…` and clicking "Setup" in the breadcrumb leads to the route `/module/site/configuration/edit` instead of `/module/site/configuration`, which means there is still an error rendered. -
Benjamin Franzke commented on patch set 1 07/08/26, 13:27
RecordBreadcrumbProvider.php:63We'd ideally revert to ``` $targetModule = $currentModule?->getIdentifier() ?? $this->getTargetModule(); ``` as changed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/91586/4/typo3/sysext/backend/Classes/Breadcrumb/RecordBreadcrumbProvider.php#b64 here, but that would break breadcrumbs like `/module/manage/search-index/Administration/externalDocuments?id=` which then loose the `externalDocuments` submodule information. ``` -
Josua Vogel uploaded patch set 2
V +107/24/26, 09:28 -
core-ci voted on patch set 2 V +1 07/24/26, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105306
-
Josua Vogel commented on patch set 2 07/24/26, 09:57
Reply
DoneRecordBreadcrumbProvider.php:63ReplyDone -
Josua Vogel uploaded patch set 3
V +107/24/26, 10:04 -
Josua Vogel commented on patch set 3 07/24/26, 10:04
RecordBreadcrumbProvider.php:263ReplyDone -
core-ci voted on patch set 3 V +1 07/24/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105307
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 07/28/26, 21:17
-
Benjamin Kott uploaded patch set 4
CR +1V +108/10/26, 22:08 -
Benjamin Kott voted on patch set 4 CR +1 V +1 08/10/26, 22:08
-
core-ci voted on patch set 4 V +1 08/10/26, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106332
-
Stefan Bürk voted on patch set 4 CR +2 V +2 08/10/26, 23:30
-
Stefan Bürk merged patch set 5 08/10/26, 23:39
RecordBreadcrumbProvider.php:263