Review main Merged

94692[TASK] Remove FAL related services from failsafe container

Benjamin Franzke CR +2 V +2 Normal +2 −73 updated 07/23/26, 09:24

Commit message

The FAL related services where introduced in #91212 to
allow the SystemEmail template upon install tool login
to use the `<f:image>` view helper, when a login highlight
color was defined.

This has been refactored with #91212 which means these services
can actually be removed again, and therefore be freed to
use full symfony dependency injection. This is particularly evident
from the fact that certain dependencies (like `FlexFormTools` or
`TaskTypeRegistry`) were not defined in the failsafe container,
meaning those services could not even be loaded in the failsafe
environment at all.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 3

Review log 1319

  1. Benjamin Franzke uploaded patch set 1 07/07/26, 07:21

  2. Benjamin Franzke uploaded patch set 2 07/07/26, 07:38

  3. Benjamin Franzke uploaded patch set 3 07/07/26, 07:39

  4. core-ci voted on patch set 3 V +1 07/07/26, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104446

  5. core-ci voted on patch set 1 V -1 07/07/26, 07:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104443

  6. Benjamin Franzke updated the commit message in patch set 4 V +1 07/07/26, 09:18

  7. core-ci voted on patch set 4 V +1 07/07/26, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104452

  8. Benjamin Franzke rebased onto patch set 5 V +1 07/07/26, 15:15

  9. core-ci voted on patch set 5 V +1 07/07/26, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104476

  10. Benni Mack uploaded patch set 6 V +1 07/17/26, 14:54

  11. core-ci voted on patch set 6 V +1 07/17/26, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104892

  12. Benni Mack uploaded patch set 7 V +1 07/22/26, 14:38

  13. core-ci voted on patch set 7 V +1 07/22/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105187

  14. Benni Mack voted on patch set 7 CR +1 V +1 07/22/26, 14:49

  15. Andreas Kienast commented on patch set 7 07/23/26, 05:13

    Is this really the correct ticket?
  16. Benjamin Franzke commented on patch set 7 07/23/26, 06:34

    Reply

    yes, indeed, albeit that's some time ago, since then it is unused/unneeded.
  17. Andreas Kienast voted on patch set 7 CR +1 V +1 07/23/26, 08:03

  18. Benjamin Franzke voted on patch set 7 CR +2 V +2 07/23/26, 09:24

  19. Benjamin Franzke merged patch set 8 07/23/26, 09:24