Review main Merged

94694[TASK] Withdraw unneeded Extbase ServiceProvider

Benjamin Franzke CR +2 V +2 Normal +7 −80 updated 07/23/26, 09:54

Commit message

The Extbase ReflectionService was a dependency to the Extbase object
container back when symfony dependency injection was introduced in
TYPO3 v10 (#88689).
The Extbase object container was needed for viewhelpers in
installtool back then and was therefore provided as a failsafe
service.

With the removal of the Extbase object container in TYPO3 v12 (#96208),
the ReflectionService is no longer needed in failsafe mode and is
therefore now moved to use regular symfony based dependency injection,
to align with other services.

The ExtensionService can be removed because it is unued in install tool
as well: No direct dependencies and viewhelpers that use this service
(`<f:flashMessages>` and `<f:form.*>`) are not used in EXT:install.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1117

  1. Benjamin Franzke uploaded patch set 1 07/07/26, 09:24

  2. Benjamin Franzke uploaded patch set 2 07/07/26, 09:27

  3. core-ci voted on patch set 2 V -1 07/07/26, 09:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104455

  4. core-ci voted on patch set 1 V -1 07/07/26, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104454

  5. Benjamin Franzke uploaded patch set 3 V -1 07/07/26, 11:54

  6. core-ci voted on patch set 3 V +1 07/07/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104460

  7. Benjamin Franzke rebased onto patch set 4 V +1 07/07/26, 15:15

  8. core-ci voted on patch set 4 V +1 07/07/26, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104478

  9. Benjamin Franzke uploaded patch set 5 V +1 07/23/26, 09:25

  10. Benjamin Franzke uploaded patch set 6 07/23/26, 09:26

  11. Benjamin Franzke commented on patch set 6 07/23/26, 09:33

    ServiceProvider.php:64

    Note: This comment was not true: Being registered in a service provider, `ExtensionService` has always been only instantiated (and extended) once. The change to use plain symfony DI (+ our inject* method compiler pass) therefore does not change functionality here.
  12. core-ci voted on patch set 5 V +1 07/23/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105229

  13. core-ci voted on patch set 6 V +1 07/23/26, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105230

  14. Andreas Kienast voted on patch set 6 CR +1 V +1 07/23/26, 09:52

  15. Benni Mack voted on patch set 6 CR +1 V +1 07/23/26, 09:53

  16. Benjamin Franzke voted on patch set 6 CR +2 V +2 07/23/26, 09:54

  17. Benjamin Franzke merged patch set 7 07/23/26, 09:54