94699[TASK] Throw error when DocHeaderComponent has multiple menus
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Oliver Klee +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oli Bartsch +1
- Oliver Klee +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1722
-
Garvin Hicking uploaded patch set 1 07/07/26, 19:16
-
core-ci voted on patch set 1 V -1 07/07/26, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104483
-
Garvin Hicking uploaded patch set 2
V -107/07/26, 19:27fix test phpstan -
core-ci voted on patch set 2 V +1 07/07/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104484
-
Jan Kornblum voted on patch set 2 CR +1 V +1 07/07/26, 20:06
-
Garvin Hicking commented on patch set 2 07/07/26, 20:14
(Not sure yet what is the best approach. Maybe logging an error instead of failing, so graceful execution can still continue?) -
Josua Vogel commented on patch set 2 07/08/26, 06:38
Reply
If only one menu is allowed, shouldn't the API be restricted so that you can't add multiple menus? The current solution isn't really ideal. -
Garvin Hicking updated the commit message in patch set 3
CR +1V +107/08/26, 07:19 -
Garvin Hicking commented on patch set 3 07/08/26, 07:21
Reply Unresolved
The point here is that MenuRegistry can be used in other places then the DocHeaderComponent. So IMO it could be valid to store multiple menus in the Registry itself, but make the consumers themself bail out of utilizing multiple menus in that context. I've contacted Oli and now only "main" throws an exception, and "v14" backport would just logg a warning. For now I don't think adding a changelog entry for this or considering it a breaking change is warranted, but open to discussion about this of course. -
core-ci voted on patch set 3 V +1 07/08/26, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104504
-
Oliver Klee voted on patch set 3 CR +1 V +1 07/08/26, 07:32
-
Oliver Klee updated the commit message in patch set 4
CR +1V +107/08/26, 07:33 -
Oliver Klee voted on patch set 4 CR +1 V +1 07/08/26, 07:33
-
core-ci voted on patch set 4 V +1 07/08/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104506
-
Josua Vogel voted on patch set 4 CR +1 V +1 07/08/26, 07:48
-
Garvin Hicking commented on patch set 5
CR +1V +107/08/26, 09:45Published edit on patch set 4. -
Oliver Klee voted on patch set 5 CR +1 V +1 07/08/26, 09:53
-
core-ci voted on patch set 5 V +1 07/08/26, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104513
-
Josua Vogel voted on patch set 5 CR +1 V +1 07/10/26, 16:59
-
Oli Bartsch voted on patch set 5 CR +1 V +1 07/21/26, 07:47
-
Garvin Hicking voted on patch set 5 CR +2 V +2 07/21/26, 07:51
-
Garvin Hicking merged patch set 6 07/21/26, 07:51