Review main Merged

94700[BUGFIX] Hide EXT:workspaces preview for non-previewable records

Garvin Hicking CR +2 V +2 Easy +2 −2 updated 07/13/26, 16:43

Commit message

The publish view of records shows both records and pages.

This means also records for `sys_file_metadata` are shown,
and a preview link points to a frontend URI that would resolve
to PID=0 (where sys_file_metadata lives), and have a follow-up
exception thrown because no valid link can be resolved for
that site.

Generally, it is hard to deduce the proper frontend URI
to be shown for filemetadata records (and most records).

The QR Code module already gates this via the `data.previewUrl`
variable, which indicates if a frontend page URI can be
properly generated or not.

Now the preview icon itself also makes use of this variable
for gating the `View` icon.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Garvin Hicking uploaded patch set 1 07/07/26, 20:27

  2. core-ci voted on patch set 1 V +1 07/07/26, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104485

  3. Benni Mack voted on patch set 1 CR +1 V +1 07/10/26, 16:54

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/10/26, 20:49

  5. Garvin Hicking voted on patch set 1 CR +2 V +2 07/13/26, 16:43

  6. Garvin Hicking merged patch set 2 07/13/26, 16:43