Review main Merged

94703[DOCS] Mention the whitespace module for ckeditor

Anja Leichsenring CR +2 V +2 Easy +9 −0 updated 09/07/26, 10:41

Commit message

The module change happend with #99454 in v12, but was never documented.
In an attempt to catch up with the old changes, this finally makes it
into the documentation. It is acompanied with a note in the Editors Guide.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Anja Leichsenring uploaded patch set 1 07/08/26, 06:57

  2. core-ci voted on patch set 1 V -1 07/08/26, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104502

  3. Anja Leichsenring commented on patch set 1 07/08/26, 07:22

    render failure due to not yet merged editors guide change at https://github.com/TYPO3-Documentation/TYPO3CMS-Tutorial-Editors/pull/294. Needs to wait until that one is in, obviously.
  4. Garvin Hicking commented on patch set 1 07/08/26, 07:25

    Reference.rst:188

    ```suggestion The shipped `whitespace` plugin ```

    Reference.rst:191

    ```suggestion :ref:`t3editors:rte-whitespace`. It replaces the former `SoftHyphen` plugin ```

    Reference.rst:193

    ```suggestion Presets that still import the old module, or reference `SoftHyphen` or ```

    Reference.rst:194

    ```suggestion `softhyphen` in the toolbar, are migrated automatically and log a console ```
  5. Anja Leichsenring rebased onto patch set 2 V -1 09/07/26, 06:35

  6. Anja Leichsenring commented on patch set 3 09/07/26, 06:37

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 09/07/26, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107978

  8. core-ci voted on patch set 2 V +1 09/07/26, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107977

  9. Anja Leichsenring commented on patch set 3 09/07/26, 06:54

    Reference.rst:188 Reply

    Fix applied.

    Reference.rst:191 Reply

    Fix applied.

    Reference.rst:193 Reply

    Fix applied.

    Reference.rst:194 Reply

    Done
  10. Garvin Hicking commented on patch set 3 CR +2 V +2 09/07/26, 07:48

    Merge as doc-change only
  11. Garvin Hicking commented on patch set 3 V 0 CR -1 09/07/26, 09:08

    13.4 backport fails, the docs of t3editors in that version do not contain the referenced anchor. Either we strike 13.4 as a backport goal, or the docs needs to receive that anchor.
  12. Garvin Hicking commented on patch set 3 CR +2 V +2 09/07/26, 10:41

    Reply

    docs were backported now
  13. Garvin Hicking merged patch set 4 09/07/26, 10:41