Review 14.3 Merged

94705[BUGFIX] Revert "[TASK] Identify remote packages by key, version and remote"

Benjamin Franzke CR +2 V +2 Hard +32 −313 updated 07/08/26, 16:20

Commit message

This reverts commit 8447102050372c65c815cbf6c881f2d136e15daa.

Reason for revert:

Local extensions can not be installed via extension manager in
classic mode, when they have not been released to TER.
They are unconditionally tried to be downloaded, because
`ExtensionService` checks if the `remote` property is a non empty
string, while it is always provided with a `'ter'` fallback in
the `createFromExtensionArray()` factory.

This means:

 * If an extension is not released to TER, it can not be installed
 * If an extension is released to TER, it is forcefully downloaded
   from TER and any local change is discarded
   (the extension is replaced with what is downloaded from TER)

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 16

Review log 34

  1. Benjamin Franzke uploaded patch set 1 07/08/26, 09:33

  2. core-ci voted on patch set 1 V +1 07/08/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104510

  3. Benni Mack commented on patch set 1 CR +2 V +2 07/08/26, 16:20

    will handle the re-introduction separately
  4. Benni Mack merged patch set 2 07/08/26, 16:20