Review main Merged

94708[BUGFIX] Ensure that failed attempts to send via MemorySpool are logged

Stephan Großberndt CR +2 V +2 Easy +1 −1 updated 07/21/26, 15:24

Commit message

During `__destruct()` at the end of the request the usual exception handling no longer works. If a PHP error occurred as in #110173 the exception was not logged. By catching all exceptions thrown here the error is logged now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Can Adrian Karadag +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 89

  1. Stephan Großberndt uploaded patch set 1 07/08/26, 13:38

  2. core-ci voted on patch set 1 V +1 07/08/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104518

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/08/26, 14:06

  4. Matthias Vogel voted on patch set 1 CR +1 V +1 07/10/26, 13:25

  5. Oliver Klee voted on patch set 1 CR +1 07/10/26, 13:35

  6. Can Adrian Karadag voted on patch set 1 CR +1 07/20/26, 09:15

  7. Markus Klein voted on patch set 1 CR +1 V +1 07/20/26, 09:42

  8. Benni Mack voted on patch set 1 CR +2 V +2 07/21/26, 15:24

  9. Benni Mack merged patch set 2 07/21/26, 15:24