94712[BUGFIX] Offer a close action after a failed wizard submission
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/wizard/steps/finisher-step.ts+2 −2
- Build/Sources/TypeScript/backend/wizard/wizard.ts+11 −4
- typo3/sysext/backend/Resources/Private/Language/Wizards/general.xlf+3 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/steps/finisher-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/wizard.js+2 −2
Review log 811
-
Benjamin Kott uploaded patch set 1 07/09/26, 07:21
-
core-ci voted on patch set 1 V +1 07/09/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104559
-
Benjamin Kott uploaded patch set 2
V +107/17/26, 07:58 -
core-ci voted on patch set 2 V +1 07/17/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104865
-
Benjamin Kott rebased onto patch set 3
V +107/20/26, 11:26 -
Benjamin Kott commented on patch set 3 07/20/26, 11:31
To test this change, the easiest way is to produce a temporary exception. Add the following to the localize method of the LocalizationController: throw new \RuntimeException('Simulated finisher failure', 1753000000); Then run the localization wizard, with and without the patch. -
core-ci voted on patch set 3 V +1 07/20/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105024
-
Georg Ringer voted on patch set 3 CR +1 V +1 09/01/26, 18:43
-
Stefan Bürk commented on patch set 3 CR +1 V +1 09/01/26, 20:02
Reply
Done -
Stefan Bürk voted on patch set 3 CR +2 V +2 09/01/26, 20:02
-
Stefan Bürk merged patch set 4 09/01/26, 20:17