Review main Merged

94712[BUGFIX] Offer a close action after a failed wizard submission

Benjamin Kott CR +2 V +2 Easy +19 −9 updated 09/01/26, 20:17

Commit message

The finisher step now treats a submission that fails with an exception
as complete, which enables the primary button. In the error case the
button reads "Close" with a matching icon, because closing the wizard
is the only action left.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Benjamin Kott uploaded patch set 1 07/09/26, 07:21

  2. core-ci voted on patch set 1 V +1 07/09/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104559

  3. Benjamin Kott uploaded patch set 2 V +1 07/17/26, 07:58

  4. core-ci voted on patch set 2 V +1 07/17/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104865

  5. Benjamin Kott rebased onto patch set 3 V +1 07/20/26, 11:26

  6. Benjamin Kott commented on patch set 3 07/20/26, 11:31

    To test this change, the easiest way is to produce a temporary exception. Add the following to the localize method of the LocalizationController: throw new \RuntimeException('Simulated finisher failure', 1753000000); Then run the localization wizard, with and without the patch.
  7. core-ci voted on patch set 3 V +1 07/20/26, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105024

  8. Georg Ringer voted on patch set 3 CR +1 V +1 09/01/26, 18:43

  9. Stefan Bürk commented on patch set 3 CR +1 V +1 09/01/26, 20:02

    Reply

    Done
  10. Stefan Bürk voted on patch set 3 CR +2 V +2 09/01/26, 20:02

  11. Stefan Bürk merged patch set 4 09/01/26, 20:17