Review main Merged

94715[BUGFIX] Allow direct publish from workspace frontend preview

Maike Kiebele CR +2 V +2 Normal +95 −1 updated 09/08/26, 14:06

Commit message

Users with publish permission could already publish records
from any stage via the mass action and selection action
dropdowns in the backend Workspaces module - unless
restricted by the publish_access flag
PUBLISH_ACCESS_ONLY_IN_PUBLISH_STAGE.

The frontend preview only offered "Send to next/previous stage" and
"Discard", so publishing required advancing
through every stage. Add a separate "Publish" button to the preview toolbar.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1828

Show 23 earlier messages
  1. Maike Kiebele uploaded patch set 1 07/09/26, 12:13

  2. core-ci voted on patch set 1 V -1 07/09/26, 12:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104566

  3. Maike Kiebele uploaded patch set 2 V -1 07/09/26, 12:33

  1. core-ci voted on patch set 2 V -1 07/09/26, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104568

  2. Maike Kiebele uploaded patch set 3 V -1 07/09/26, 13:20

  3. core-ci voted on patch set 3 V +1 07/09/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104570

  4. Benni Mack commented on patch set 3 07/10/26, 05:48

    Hey Maike, thanks for the patch. Can you change the commit message two add a second paragraph. "It was already possible ... ... now there is a separate button on each record in the list of items..."
  5. Maike Kiebele updated the commit message in patch set 4 V +1 07/10/26, 06:54

  6. core-ci voted on patch set 4 V +1 07/10/26, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104594

  7. Philipp Kitzberger commented on patch set 4 07/11/26, 10:17

    WorkspacesAjaxController.php:662

    @maike.kiebele@gmail.com, thanks for implementing that. it's generally working as expected! one thing though: this part seems to be not strict enough. the new button is rendered independently of whether or not there's open changes. meaning after hitting "publish directly" (and the split view reloads) that button is still present and indicating there's more open changes (which there isn't of course).
  8. Maike Kiebele uploaded patch set 5 V +1 07/20/26, 14:18

  9. core-ci voted on patch set 5 V -1 07/20/26, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105034

  10. Maike Kiebele uploaded patch set 6 V -1 07/21/26, 07:21

  11. core-ci voted on patch set 6 V -1 07/21/26, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105075

  12. Maike Kiebele uploaded patch set 7 V -1 07/21/26, 12:25

  13. core-ci voted on patch set 7 V +1 07/21/26, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105099

  14. Maike Kiebele commented on patch set 7 07/27/26, 07:24

    Reply

    Done

    WorkspacesAjaxController.php:662 Reply

    Thank you. I fixed that.
  15. Maike Kiebele rebased onto patch set 8 V +1 08/06/26, 18:26

  16. core-ci voted on patch set 8 V +1 08/06/26, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106012

  17. Benni Mack uploaded patch set 9 V +1 09/03/26, 23:46

  18. core-ci voted on patch set 9 V +1 09/03/26, 23:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107788

  19. Benni Mack voted on patch set 9 CR +1 V +1 09/04/26, 12:58

  20. Benni Mack rebased onto patch set 10 CR +1 V +1 09/07/26, 16:38

  21. Benni Mack marked it ready for review 09/07/26, 16:39

  22. core-ci voted on patch set 10 V +1 09/07/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108016

  23. Wouter Wolters voted on patch set 10 CR +1 V +1 09/07/26, 18:30

  24. Benni Mack voted on patch set 10 CR +2 V +2 09/08/26, 14:06

  25. Benni Mack merged patch set 11 09/08/26, 14:06