Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
94753[FEATURE] New TCA type "coordinate"
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 10
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/53/94753/10 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/53/94753/10 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 92
- Build/Scripts/setupAcceptanceComposer.sh+1 −0
- Build/Sources/TypeScript/backend/form-engine/coordinate-provider/geolocation.tsnew+41 −0
- Build/Sources/TypeScript/backend/form-engine/coordinate-provider/leaflet.ts1new+188 −0
- Build/Sources/TypeScript/backend/form-engine/element/coordinate-element.ts1new+215 −0
- Build/tests/packages/coordinate_demo/Classes/BasemapAtCoordinateProvider.phpnew+65 −0
- Build/tests/packages/coordinate_demo/Classes/GoogleMapsCoordinateProvider.phpnew+95 −0
- Build/tests/packages/coordinate_demo/Classes/StaticListCoordinateProvider.phpnew+64 −0
- Build/tests/packages/coordinate_demo/Configuration/TCA/Overrides/tx_styleguide_elements_basic.phpnew+28 −0
- Build/tests/packages/coordinate_demo/Configuration/JavaScriptModules.phpnew+8 −0
- Build/tests/packages/coordinate_demo/Configuration/Services.yamlnew+8 −0
- Build/tests/packages/coordinate_demo/Resources/Public/JavaScript/google-maps-provider.jsnew+82 −0
- Build/tests/packages/coordinate_demo/Resources/Public/JavaScript/static-list-provider.jsnew+50 −0
- Build/tests/packages/coordinate_demo/Resources/Public/Json/places.jsonnew+7 −0
- Build/tests/packages/coordinate_demo/composer.jsonnew+25 −0
- Build/tests/packages/coordinate_demo/ext_conf_template.txtnew+2 −0
- Build/tests/playwright/e2e/form-engine/elements-basic-coordinate.spec.tsnew+194 −0
- Build/Gruntfile.js+7 −0
- Build/package-lock.json+25 −0
- Build/package.json+2 −0
- typo3/sysext/backend/Classes/Form/Coordinate/AddCoordinateProviderContentSecurityPolicy.phpnew+196 −0
Show 72 more files
- typo3/sysext/backend/Classes/Form/Coordinate/CoordinateProviderContext.phpnew+38 −0
- typo3/sysext/backend/Classes/Form/Coordinate/CoordinateProviderInterface.phpnew+48 −0
- typo3/sysext/backend/Classes/Form/Coordinate/CoordinateProviderRegistry.phpnew+51 −0
- typo3/sysext/backend/Classes/Form/Coordinate/CoordinateProviderResult.phpnew+38 −0
- typo3/sysext/backend/Classes/Form/Coordinate/GeolocationCoordinateProvider.phpnew+49 −0
- typo3/sysext/backend/Classes/Form/Coordinate/OpenStreetMapCoordinateProvider.phpnew+74 −0
- typo3/sysext/backend/Classes/Form/Element/CoordinateElement.phpnew+218 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCoordinate.phpnew+43 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+5 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+11 −3
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/coordinate-provider/geolocation.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/coordinate-provider/leaflet.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/coordinate-element.jsnew+13 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_coordinate_provider/Classes/ContextEchoProvider.phpnew+63 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_coordinate_provider/Classes/UnavailableProvider.phpnew+43 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_coordinate_provider/Configuration/FlexForms/ContextEcho.xmlnew+21 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_coordinate_provider/Configuration/Services.yamlnew+8 −0
- typo3/sysext/backend/Tests/Functional/Fixtures/Extensions/test_coordinate_provider/composer.jsonnew+24 −0
- typo3/sysext/backend/Tests/Functional/Form/Coordinate/CoordinateProviderContentSecurityPolicyTest.phpnew+256 −0
- typo3/sysext/backend/Tests/Functional/Form/Element/CoordinateElementTest.phpnew+212 −0
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+43 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCoordinateTest.phpnew+64 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+40 −0
- typo3/sysext/core/Classes/Coordinate/Coordinate.phpnew+147 −0
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+10 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+16 −0
- typo3/sysext/core/Classes/DataHandling/RecordFieldTransformer.php+4 −0
- typo3/sysext/core/Classes/DataHandling/TableColumnType.php+1 −0
- typo3/sysext/core/Classes/Schema/Field/CoordinateFieldType.phpnew+31 −0
- typo3/sysext/core/Classes/Schema/FieldTypeFactory.php+2 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+12 −0
- typo3/sysext/core/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111177-NewTCATypeCoordinate.rstnew+118 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+33 −0
- typo3/sysext/core/Resources/Public/Css/Contrib/leaflet.cssnew+661 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/leaflet.jsnew+9 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Coordinate.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/CoordinateTest.phpnew+110 −0
- typo3/sysext/core/Tests/Functional/DataHandling/RecordFieldTransformerTest.php+64 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/Overrides/tt_content.php+9 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_relation_resolver/Configuration/TCA/Overrides/tt_content.php+16 −1
- typo3/sysext/core/Tests/Unit/Coordinate/CoordinateTest.phpnew+180 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+44 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php+9 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+9 −0
- typo3/sysext/extbase/Classes/Property/TypeConverter/CoordinateConverter.phpnew+46 −0
- typo3/sysext/extbase/Classes/Utility/TypeHandlingUtility.php+1 −1
- typo3/sysext/extbase/Configuration/Services.yaml+7 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Person.php+13 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php+7 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/ColumnMapFactoryTest.php+1 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/TcaTypeCoordinateTest.phpnew+88 −0
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/CoordinateConverterTest.phpnew+69 −0
- typo3/sysext/lowlevel/Classes/Controller/QuerySearchController.php+2 −1
- typo3/sysext/styleguide/Classes/Controller/CoordinateDistanceController.phpnew+109 −0
- typo3/sysext/styleguide/Classes/Service/CoordinateDistanceCalculator.phpnew+75 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeCoordinate.phpnew+47 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/GeneratorFrontend.php+26 −0
- typo3/sysext/styleguide/Configuration/FlexForms/CoordinateDistance.xmlnew+40 −0
- typo3/sysext/styleguide/Configuration/TCA/Overrides/tt_content.php+57 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+24 −0
- typo3/sysext/styleguide/Configuration/Services.yaml+3 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang_coordinate_distance.xlfnew+65 −0
- typo3/sysext/styleguide/Resources/Private/Partials/CoordinateDistance.fluid.htmlnew+39 −0
- typo3/sysext/styleguide/Resources/Private/Templates/CoordinateDistance/FlexForm.fluid.htmlnew+3 −0
- typo3/sysext/styleguide/Resources/Private/Templates/CoordinateDistance/Tca.fluid.htmlnew+3 −0
- typo3/sysext/styleguide/Tests/Functional/Controller/CoordinateDistanceControllerTest.phpnew+83 −0
- typo3/sysext/styleguide/Tests/Unit/Service/CoordinateDistanceCalculatorTest.phpnew+71 −0
- typo3/sysext/styleguide/composer.json+4 −1
- typo3/sysext/styleguide/ext_localconf.php+12 −0
- composer.json+2 −0
Review log 1719
-
Georg Ringer uploaded patch set 1 07/10/26, 13:15
-
Georg Ringer uploaded patch set 2 10/01/26, 20:39
-
Georg Ringer commented on patch set 2 10/01/26, 20:44
This change is ready for review. -
Garvin Hicking commented on patch set 2 10/02/26, 05:26
Feature-00000-NewTCATypeCoordinate.rst:81Dont know if its technically feasible, but wouldn't it be cool to make the provider emit the csp rules by itself? When rendering it could dynamically apy the csp rule needed? -
Georg Ringer uploaded patch set 3 10/02/26, 06:46
-
Garvin Hicking uploaded patch set 4 10/20/26, 13:19
Replace LLL EXT with language domains -
Garvin Hicking uploaded patch set 5 10/20/26, 13:27
add styleguide frontend extbase demo plugin -
Garvin Hicking uploaded patch set 6 10/20/26, 13:29
More tests some failing -
Garvin Hicking uploaded patch set 7 10/20/26, 13:30
More tests hopefully succeeding -
Garvin Hicking uploaded patch set 8 10/20/26, 13:45
Flexform integration -
Garvin Hicking commented on patch set 8 CR +1 V +1 10/20/26, 13:48
lgtmFeature-00000-NewTCATypeCoordinate.rst:81ReplyDone -
Georg Ringer marked it ready for review 10/20/26, 13:54
-
Georg Ringer wrote 10/20/26, 14:00
Unset private -
Georg Ringer marked it work in progress 10/20/26, 14:00
-
Garvin Hicking rebased onto patch set 9
CR +1V +110/20/26, 14:27 -
core-ci voted on patch set 9 V -1 10/20/26, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111848
-
Garvin Hicking uploaded patch set 10
V -110/20/26, 16:50us JSONB for pgsql compat on distinct equality -
core-ci voted on patch set 10 V +1 10/20/26, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111896
-
Simon Schaufelberger commented on patch set 10 10/27/26, 00:52
Unresolved
Pure code style feedback for now. Will review later in detail as I'm a heavy user of leaflet in the backendleaflet.ts:188Unresolved2 empty linescoordinate-element.ts:204UnresolvedRemove empty line