94756[BUGFIX] Sanitize and size SVG via dedicated SvgDocument classes
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
-
Verified V +2 Done
- Georg Ringer +2
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/backend/Classes/ViewHelpers/LoginLogoViewHelper.php+13 −30
- typo3/sysext/core/Classes/Imaging/Exception/InvalidSvgException.phpnew+25 −0
- typo3/sysext/core/Classes/Imaging/IconProvider/AbstractSvgIconProvider.php+22 −7
- typo3/sysext/core/Classes/Imaging/Svg/SvgDocument.phpnew+32 −0
- typo3/sysext/core/Classes/Imaging/Svg/SvgDocumentFactory.phpnew+99 −0
- typo3/sysext/core/Classes/Imaging/Svg/SvgDocumentService.phpnew+195 −0
- typo3/sysext/core/Classes/Imaging/SvgManipulation.phpdeleted+0 −196
- typo3/sysext/core/Classes/Resource/Processing/SvgImageProcessor.php+29 −24
- typo3/sysext/core/Classes/Resource/Security/SvgSanitizer.php+12 −1
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+19 −22
- typo3/sysext/core/Classes/ServiceProvider.php+38 −0
- typo3/sysext/core/Configuration/Services.php+5 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgIconProviderTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgSpriteIconProviderTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Resource/Security/SvgSanitizerTest.php+39 −0
- typo3/sysext/core/Tests/Unit/Imaging/Svg/SvgDocumentFactoryTest.phpnew+129 −0
- typo3/sysext/core/Tests/Unit/Imaging/Svg/SvgDocumentServiceTest.phpnew+246 −0
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+3 −1
- typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php+16 −11
Review log 34
-
Georg Ringer commented on patch set 1 07/10/26, 13:44
Cherry Picked from branch main. -
core-ci voted on patch set 1 V +1 07/10/26, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104635
-
Georg Ringer voted on patch set 1 CR +2 V +2 07/10/26, 18:28
-
Georg Ringer merged patch set 2 07/10/26, 18:28