Review main Merged

94757[BUGFIX] Hand correlationId over to sub instances of DataHandler

Benni Mack CR +2 V +2 Normal +101 −28 updated 07/24/26, 13:49

Commit message

A single logical editor action frequently spawns nested DataHandler
instances internally: copying a page copies its content elements via
sub instances, localizing records processes child commands through a
separate DataHandler in DataMapProcessor, and workspace auto-versioning
as well as cascading deletes of related records do the same.

Since DataHandler::start() unconditionally generated a fresh
correlation id per instance, the sys_history entries of one and the
same operation were scattered across several unrelated correlation
scopes. As a result, any functionality resolving an operation via
RecordHistory::findEventsForCorrelation() - such as the rollback of
redirects - only saw the changes made by the outermost
instance and silently missed everything written by sub instances.

DataHandler::start() now accepts an optional CorrelationId which all
internal sub instance call sites (including DataMapProcessor) pass
down the chain, mirroring the existing ReferenceIndexUpdater
pass-through. All history entries of one logical operation therefore
share the correlation scope of the outermost instance, making the
operation traceable and revertable as a whole.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Benni Mack uploaded patch set 1 07/10/26, 16:31

  2. core-ci voted on patch set 1 V +1 07/10/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104638

  3. Benni Mack updated the commit message in patch set 2 V +1 07/22/26, 10:48

  4. Benni Mack marked it ready for review 07/22/26, 10:48

  5. core-ci voted on patch set 2 V +1 07/22/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105158

  6. Daniel Windloff commented on patch set 2 07/22/26, 11:04

    I would suggest deprecating or removing ` DataHandler ->setCorrelationId()` and replacing the remaining usages in `SlugService` with the new parameter in `DataHandler->start()` as well.
  7. Benni Mack rebased onto patch set 3 V +1 07/22/26, 11:44

  8. Benni Mack uploaded patch set 4 07/22/26, 11:46

  9. Benni Mack commented on patch set 4 07/22/26, 11:47

    Reply

    I think we should handle the deprecation later, as I want this change to go in 14.3 as well (= thus, deprecation can be main-only)
  10. core-ci voted on patch set 3 V +1 07/22/26, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105167

  11. Daniel Windloff commented on patch set 4 07/22/26, 11:56

    Reply

    Acknowledged
  12. core-ci voted on patch set 4 V +1 07/22/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105168

  13. Stefan Bürk voted on patch set 4 CR +1 V +1 07/24/26, 11:16

  14. Garvin Hicking voted on patch set 4 CR +1 V +1 07/24/26, 13:46

  15. Benni Mack voted on patch set 4 CR +2 V +2 07/24/26, 13:49

  16. Benni Mack merged patch set 5 07/24/26, 13:49