94757[BUGFIX] Hand correlationId over to sub instances of DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+15 −11
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+13 −10
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/CorrelationId/PagesWithContent.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/CorrelationIdTest.phpnew+60 −0
- typo3/sysext/redirects/Classes/Service/SlugService.php+5 −7
Review log 1216
-
Benni Mack uploaded patch set 1 07/10/26, 16:31
-
core-ci voted on patch set 1 V +1 07/10/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104638
-
Benni Mack updated the commit message in patch set 2
V +107/22/26, 10:48 -
Benni Mack marked it ready for review 07/22/26, 10:48
-
core-ci voted on patch set 2 V +1 07/22/26, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105158
-
Daniel Windloff commented on patch set 2 07/22/26, 11:04
I would suggest deprecating or removing ` DataHandler ->setCorrelationId()` and replacing the remaining usages in `SlugService` with the new parameter in `DataHandler->start()` as well. -
Benni Mack rebased onto patch set 3
V +107/22/26, 11:44 -
Benni Mack uploaded patch set 4 07/22/26, 11:46
-
Benni Mack commented on patch set 4 07/22/26, 11:47
Reply
I think we should handle the deprecation later, as I want this change to go in 14.3 as well (= thus, deprecation can be main-only) -
core-ci voted on patch set 3 V +1 07/22/26, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105167
-
Daniel Windloff commented on patch set 4 07/22/26, 11:56
Reply
Acknowledged -
core-ci voted on patch set 4 V +1 07/22/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105168
-
Stefan Bürk voted on patch set 4 CR +1 V +1 07/24/26, 11:16
-
Garvin Hicking voted on patch set 4 CR +1 V +1 07/24/26, 13:46
-
Benni Mack voted on patch set 4 CR +2 V +2 07/24/26, 13:49
-
Benni Mack merged patch set 5 07/24/26, 13:49