Review main Merged

94758[TASK] Use DependencyInjection over makeInstance

Benni Mack CR +2 V +2 Hard +164 −106 updated 07/17/26, 18:36

Commit message

This focusses on DI for Services that are marked
as SingletonInterface. In order to remove
SingletonInterface and use the DI container

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 39

Show 19 more files

Review log 1219

  1. Benni Mack uploaded patch set 1 07/10/26, 16:33

  2. core-ci voted on patch set 1 V -1 07/10/26, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104639

  3. Benni Mack rebased onto patch set 2 V -1 07/13/26, 14:44

  4. core-ci voted on patch set 2 V -1 07/13/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104720

  5. Benni Mack uploaded patch set 3 V -1 07/15/26, 10:59

  6. core-ci voted on patch set 3 V -1 07/15/26, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104784

  7. Benni Mack uploaded patch set 4 V -1 07/15/26, 12:21

  8. core-ci voted on patch set 4 V -1 07/15/26, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104788

  9. Benni Mack uploaded patch set 5 V -1 07/17/26, 11:44

  10. Benni Mack updated the commit message in patch set 6 07/17/26, 11:45

  11. Benni Mack updated the commit message in patch set 7 07/17/26, 11:46

  12. Benni Mack marked it ready for review 07/17/26, 11:46

  13. core-ci voted on patch set 5 V +1 07/17/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104877

  14. core-ci voted on patch set 7 V +1 07/17/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104879

  15. core-ci voted on patch set 6 V +1 07/17/26, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104878

  16. Stefan Bürk voted on patch set 7 CR +1 V +1 07/17/26, 14:04

  17. Garvin Hicking voted on patch set 7 CR +1 V +1 07/17/26, 18:36

  18. Benni Mack voted on patch set 7 CR +2 V +2 07/17/26, 18:36

  19. Benni Mack merged patch set 8 07/17/26, 18:36