94759[TASK] Address PHPStan complaints in Rfc822AddressesParser
Commit message
Review
-
Code review CR -1
- Oliver Klee +1
- Garvin Hicking -1
- Simon Schaufelberger +1
-
Verified V -1
- Oliver Klee +1
- Garvin Hicking -1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2024
-
Garvin Hicking uploaded patch set 1 07/10/26, 16:59
-
core-ci voted on patch set 1 V +1 07/10/26, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104640
-
Oliver Klee commented on patch set 1 07/11/26, 11:25
-
Garvin Hicking commented on patch set 1 07/11/26, 11:49
Rfc822AddressesParser.php:196ReplySure, please go ahead to adjust this. -
Oliver Klee commented on patch set 2
V +107/11/26, 11:55Published edit on patch set 1. -
Oliver Klee commented on patch set 2 07/11/26, 11:56
Rfc822AddressesParser.php:196ReplyOkay, I've given it a try (from the browser as I'm on the road without a development machine with me). -
core-ci voted on patch set 2 V -1 07/11/26, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104662
-
Oliver Klee commented on patch set 2 07/11/26, 12:15
This reads like a false positive from PHPStan to me. Should we add it to the baseline? WDYT? -
Garvin Hicking commented on patch set 2 07/11/26, 13:20
Reply
Ah wait now I remember, this was my bulletpoint 3 - definitely a phpstan inability to track the changed property. I'd like to not have a baseline entry so eigher we keeo it like patchset 1 or we add a phphstan-ignore inline. Midterm I'd like to remove this whole class in our domain. -
Oliver Klee commented on patch set 2 07/11/26, 16:18
Reply
Then let's revert to patchset 1 plus the improved PHPDoc for the property. -
Garvin Hicking commented on patch set 3
V -107/11/26, 18:17Published edit on patch set 2. -
Garvin Hicking commented on patch set 4 07/11/26, 18:18
Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 07/11/26, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104664
-
core-ci voted on patch set 3 V -1 07/11/26, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104663
-
Oliver Klee voted on patch set 4 CR +1 07/11/26, 18:44
-
Oliver Klee commented on patch set 4 07/11/26, 18:44
Reply
Done -
Oliver Klee voted on patch set 4 V +1 07/11/26, 21:23
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 07/12/26, 09:06
-
Markus Klein commented on patch set 4 07/12/26, 09:41
Rfc822AddressesParser.php:92This type repeats 3 times now. I propse to declare a phpstan-type at the top and give this structure a name.Rfc822AddressesParser.php:196Not sure if we really need this here? We have this exact type at the property now.Rfc822AddressesParser.php:764Is this really correct? Shouldn't this be `|| $matches[1] !== '\\'` -
Oliver Klee commented on patch set 4 07/12/26, 21:31
Rfc822AddressesParser.php:196ReplyYes, unfortunately PHPStan cannot track this if we have the PHPDoc only for the property. (I tried this in changeset 2.) -
Garvin Hicking commented on patch set 4 07/13/26, 06:15
Rfc822AddressesParser.php:92Reply UnresolvedNot sure if it's worth this when I'd like to remove the whole class eventually with a better dependency or implementation. But feel free to do it! :)Rfc822AddressesParser.php:764Reply UnresolvedI've went through this a couple of time and believed PHPStan was right. The only place this is used has a \\ precondition, but reading it for the fourth time now makes even less sense. Yeah, needs a better explanation because if it's so now I don't see how the method is working at all 🤪 -
Garvin Hicking commented on patch set 4 CR -1 V -1 07/13/26, 16:43
Unresolved
I think the class needs to go now. Will check it out with Benni -
Garvin Hicking marked it work in progress 07/13/26, 16:43
-
Garvin Hicking abandoned the change 07/17/26, 06:07
Rfc822AddressesParser.php:196