Review main Merged

94762[BUGFIX] Respect required but not rendered fields in Page Wizard

Georg Ringer CR +2 V +2 Normal +73 −1 updated 07/16/26, 14:26

Commit message

If a field is required but not shown - e.g. because of a displayCond -
it must not be shown in the required step.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Lisa Kreitz +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Lisa Kreitz +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Georg Ringer uploaded patch set 1 07/10/26, 18:58

  2. Georg Ringer commented on patch set 1 07/10/26, 18:59

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/10/26, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104643

  4. Lisa Kreitz voted on patch set 1 CR +1 V +1 07/11/26, 09:04

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/14/26, 08:45

  6. Benjamin Franzke commented on patch set 1 07/16/26, 07:57

    Seems like properly supporting `displayCond` will require quite some refactoring, since field values are not evaluated right now. This patch fixes the case were displayCond becomes `false` – and therefore is for sure needed, but will not fix where they should become `true`. but I guess we need to handle that in a separate fix, since it will also require JS adaptions.

    PageWizardStepBuilder.php:72

    Hm, the intersection basically calculates if `columns` is non empty, right? I guess this would be equal to: ```suggestion $columns = $formData['processedTca']['columns'] ?? []; if ($columns !== []) { ``` (or do you see a difference?)
  7. Benjamin Kott commented on patch set 1 CR +2 V +2 07/16/26, 14:16

    PageWizardStepBuilder.php:72 Reply

    as discussed, intersection is nessesary here is 'columns' can contain additional fields
  8. Benjamin Kott commented on patch set 1 07/16/26, 14:16

    PageWizardStepBuilder.php:72 Reply

    Done
  9. Benjamin Kott merged patch set 2 07/16/26, 14:26