Review main Ready for review Stale

94763[BUGFIX] Allow publishing translation parent changes in workspaces

Philipp Kitzberger CR 0 V 0 Normal +120 −3 updated 07/12/26, 08:40

Commit message

Changing the translation parent pointer (transOrigPointerField, e.g.
tt_content.l18n_parent) of a record within a workspace is displayed as
a change in the workspace diff view, but the change is silently lost
when the record is published.

DataHandlerHook::version_swap() unconditionally adds the pointer field
to the list of "keep fields". Those fields are swapped back from the
live record onto the versioned record while publishing, so the live
record keeps its previous value, while the changed value ends up on the
versioned record - which is deleted right afterwards. As a result,
neither connecting a free-mode translation to a translation origin nor
decoupling a translation from its origin can be published.

The pointer field is now only kept when it has not been changed within
the workspace. An intentional change is therefore published as
expected, while unchanged records keep their translation connection.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/63/94763/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/63/94763/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 1

Files 2

Review log 12

  1. Philipp Kitzberger uploaded patch set 1 07/12/26, 08:32

  2. core-ci voted on patch set 1 V +1 07/12/26, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104682