Review main Merged

94764[BUGFIX] Show workspace indicator for page translation changes

Philipp Kitzberger CR +2 V +2 Normal +39 −14 updated 09/03/26, 19:01

Commit message

The pagetree workspace indicator dot was missing when only page
translations (sys_language_uid > 0) were modified in a workspace.
The getPageUidsWithVersionedRecords() method skipped the "pages"
table entirely, so page translation workspace versions and their
l10n_parent relationship to the default-language tree node were
never checked.

A targeted query now checks for page translations with workspace
changes and maps their l10n_parent to the default-language page
that should receive the indicator.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Riccardo De Contardi +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Philipp Kitzberger uploaded patch set 1 07/12/26, 09:39

  2. core-ci voted on patch set 1 V +1 07/12/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104683

  3. Riccardo De Contardi commented on patch set 1 V +1 08/07/26, 08:27

    tested on latest main
  4. Georg Ringer voted on patch set 1 CR +1 V +1 09/03/26, 18:18

  5. Benni Mack voted on patch set 1 CR +1 V +1 09/03/26, 18:46

  6. Georg Ringer voted on patch set 1 CR +2 V +2 09/03/26, 19:01

  7. Georg Ringer merged patch set 2 09/03/26, 19:01