Review main Merged

94766[TASK] Remove unused method `DataHandler->setHistory()`

Daniel Windloff CR +2 V +2 Easy +1 −22 updated 08/26/26, 08:41

Commit message

The internal method  `DataHandler->setHistory()`
has been removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Daniel Windloff uploaded patch set 1 07/12/26, 11:07

  2. core-ci voted on patch set 1 V +1 07/12/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104685

  3. Benni Mack voted on patch set 1 CR +1 V +1 07/13/26, 04:57

  4. Josua Vogel voted on patch set 1 CR +1 V +1 07/13/26, 05:45

  5. Josua Vogel commented on patch set 1 07/13/26, 05:47

    Maybe we should update the method comment on getRecordHistoryStore() too? "This is needed as DataHandler would usually trigger the setHistory()" ...
  6. Daniel Windloff uploaded patch set 2 CR +1 V +1 08/15/26, 05:47

  7. Daniel Windloff commented on patch set 2 08/15/26, 05:48

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 08/15/26, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106753

  9. Georg Ringer voted on patch set 2 CR +1 V +1 08/15/26, 08:05

  10. Josua Vogel voted on patch set 2 CR +1 V +1 08/19/26, 09:24

  11. Benni Mack voted on patch set 2 CR +2 V +2 08/26/26, 08:41

  12. Benni Mack merged patch set 3 08/26/26, 08:41