Review main Merged

94775[BUGFIX] Cascade undelete for foreign_field inline records

Kay Wienöbst CR +2 V +2 Normal +61 −2 updated 07/24/26, 15:34

Commit message

Move the `undeleteRecord = true` assignment in
DataHandler::undeleteRecordRelations() before the
RelationHandler::start() call. readForeignField() evaluates the
flag on entry to decide whether a DeletedRestriction is applied;
setting it afterwards leaves the SELECT filtering out the very
soft-deleted children the undelete cascade is meant to restore.

The same before-start() ordering is already used in
deleteRecord_procFields() for the forceHardDelete branch.

A functional test covering delete-then-undelete of a parent with
inline foreign_field relations is added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Kay Wienöbst uploaded patch set 1 07/14/26, 09:28

  2. core-ci voted on patch set 1 V -1 07/14/26, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104747

  3. core-ci voted on patch set 1 V +1 07/14/26, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104747

  4. Georg Ringer voted on patch set 1 CR +1 V +1 07/14/26, 18:23

  5. Garvin Hicking commented on patch set 1 CR +1 V +1 07/14/26, 19:29

    lgtm ;)
  6. Benni Mack voted on patch set 1 CR +2 V +2 07/24/26, 15:34

  7. Benni Mack merged patch set 2 07/24/26, 15:34