Review main Merged Breaking

94781[!!!][TASK] Remove Rfc822AddressesParser

Benni Mack CR +2 V +2 Expert +305 −881 updated 07/17/26, 05:49

Commit message

The PHP class TYPO3\CMS\Core\Mail\Rfc822AddressesParser, a
modernized copy of the PEAR package pear/mail from 2010, is
removed. Its only usage in MailUtility::parseAddresses() is
now based on symfony/mime, which TYPO3 already utilizes for
composing and sending emails.

As a side effect, display names parsed from mailboxes such as
'"last, first" <email@example.org>' no longer keep their
surrounding double quotes, as symfony/mime applies proper
quoting itself when composing a mail message.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1519

  1. Benni Mack uploaded patch set 1 07/14/26, 12:15

  2. core-ci voted on patch set 1 V +1 07/14/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104755

  3. Garvin Hicking commented on patch set 1 07/14/26, 15:34

    Mailer.php:114

    When using a custom MailerInterface implementation, consumers need to implement this too, right? Then we need to add these methods to the interface (and have it be breaking?)

    MailUtility.php:215

    Is "bla < foo" <no@example.com> An issue here, if <> hapoens within the name? Or is that forbidden per RFC? (Note to self to check)

    MailUtility.php:351

    This kind of tingles my "can one exploit this by putting another backlsash into it" spidey sense "\\\\\X" would be turned into "\"?! Could that cause harm?

    MailUtilityTest.php:27

    ```suggestion * @todo: Remove together with MailUtility in TYPO3 v16.0 * @deprecated since 15.0 ```

    AuthenticationService.php:171

    the mailer name fallback is now missing, or did you find out it never gets used because the mail address will always be set due to DefaultConfiguration getting applied, right?
  4. Benni Mack uploaded patch set 2 V +1 07/15/26, 13:01

  5. core-ci voted on patch set 2 V +1 07/15/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104792

  6. Benni Mack marked it ready for review 07/15/26, 13:16

  7. Garvin Hicking commented on patch set 2 07/15/26, 13:21

    MailUtility.php:189

    (╯°□°)╯︵ ┻━┻ (ノ>。<)ノミ┻┻

    MailUtility.php:197

    `Throwable`?
  8. Garvin Hicking commented on patch set 2 CR +1 07/15/26, 13:27

    MailUtility.php:189 Reply

    Done

    MailUtility.php:215 Reply

    Done

    MailUtility.php:351 Reply

    Done

    MailUtilityTest.php:27 Reply

    Done

    MailUtilityTest.php:97

    Let's keep the new added tests from patchset 1 (or do they fail?)
  9. Garvin Hicking uploaded patch set 3 CR +1 V +1 07/15/26, 13:58

    add failing tests
  10. core-ci voted on patch set 3 V -1 07/15/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104800

  11. Benni Mack commented on patch set 3 07/15/26, 14:33

    Mailer.php:114 Reply

    Done

    AuthenticationService.php:171 Reply

    Done
  12. Benni Mack uploaded patch set 4 V -1 07/16/26, 08:14

  13. core-ci voted on patch set 4 V +1 07/16/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104827

  14. Benni Mack commented on patch set 4 07/16/26, 08:46

    This change is ready for review.

    MailUtility.php:197 Reply

    Done

    MailUtilityTest.php:97 Reply

    Done
  15. Garvin Hicking voted on patch set 4 CR +1 V +1 07/16/26, 09:18

  16. Oliver Klee voted on patch set 4 V +1 07/16/26, 21:04

  17. Andreas Kienast voted on patch set 4 CR +1 V +1 07/17/26, 05:41

  18. Benni Mack voted on patch set 4 CR +2 V +2 07/17/26, 05:49

  19. Benni Mack merged patch set 5 07/17/26, 05:49