94781[!!!][TASK] Remove Rfc822AddressesParser
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 7
- Build/php-cs-fixer/header-comment.php+0 −1
- Build/phpstan/phpstan-baseline.neon+0 −42
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.phpdeleted+0 −825
- typo3/sysext/core/Classes/Utility/MailUtility.php8+165 −11
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110196-Rfc822AddressesParserRemoved.rstnew+61 −0
- typo3/sysext/core/Tests/Unit/Utility/MailUtilityTest.php4+74 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 1519
-
Benni Mack uploaded patch set 1 07/14/26, 12:15
-
core-ci voted on patch set 1 V +1 07/14/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104755
-
Garvin Hicking commented on patch set 1 07/14/26, 15:34
MailUtility.php:215Is "bla < foo" <no@example.com> An issue here, if <> hapoens within the name? Or is that forbidden per RFC? (Note to self to check)MailUtility.php:351This kind of tingles my "can one exploit this by putting another backlsash into it" spidey sense "\\\\\X" would be turned into "\"?! Could that cause harm?MailUtilityTest.php:27```suggestion * @todo: Remove together with MailUtility in TYPO3 v16.0 * @deprecated since 15.0 ```AuthenticationService.php:171the mailer name fallback is now missing, or did you find out it never gets used because the mail address will always be set due to DefaultConfiguration getting applied, right? -
Benni Mack uploaded patch set 2
V +107/15/26, 13:01 -
core-ci voted on patch set 2 V +1 07/15/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104792
-
Benni Mack marked it ready for review 07/15/26, 13:16
-
Garvin Hicking commented on patch set 2 07/15/26, 13:21
MailUtility.php:189(╯°□°)╯︵ ┻━┻ (ノ>。<)ノミ┻┻MailUtility.php:197`Throwable`? -
Garvin Hicking commented on patch set 2 CR +1 07/15/26, 13:27
MailUtility.php:189ReplyDoneMailUtility.php:215ReplyDoneMailUtility.php:351ReplyDoneMailUtilityTest.php:27ReplyDoneMailUtilityTest.php:97Let's keep the new added tests from patchset 1 (or do they fail?) -
Garvin Hicking uploaded patch set 3
CR +1V +107/15/26, 13:58add failing tests -
core-ci voted on patch set 3 V -1 07/15/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104800
-
Benni Mack commented on patch set 3 07/15/26, 14:33
Mailer.php:114ReplyDoneAuthenticationService.php:171ReplyDone -
Benni Mack uploaded patch set 4
V -107/16/26, 08:14 -
core-ci voted on patch set 4 V +1 07/16/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104827
-
Benni Mack commented on patch set 4 07/16/26, 08:46
This change is ready for review.MailUtility.php:197ReplyDoneMailUtilityTest.php:97ReplyDone -
Garvin Hicking voted on patch set 4 CR +1 V +1 07/16/26, 09:18
-
Oliver Klee voted on patch set 4 V +1 07/16/26, 21:04
-
Andreas Kienast voted on patch set 4 CR +1 V +1 07/17/26, 05:41
-
Benni Mack voted on patch set 4 CR +2 V +2 07/17/26, 05:49
-
Benni Mack merged patch set 5 07/17/26, 05:49
Mailer.php:114