Review main Merged

94787[BUGFIX] Evaluate sortDesc parameter correctly in indexed_search

Tobias Wojtylak CR +2 V +2 Easy +2 −3 updated 07/23/26, 11:54

Commit message

The IndexedSearchRepository method getDescendingSortOrderFlag()
wrongly returned descending order ('DESC') when sortDesc was 0,
and an empty string (defaulting to 'ASC') when sortDesc was 1.

The logic is now corrected:
- If sortDesc is 1, sort order is 'DESC'.
- Otherwise, sort order defaults to 'ASC'.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Thomas Maroschik +1
  • Verified V +2 Done
    • Benni Mack +2
    • Thomas Maroschik +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Tobias Wojtylak uploaded patch set 1 07/15/26, 06:46

  2. core-ci voted on patch set 1 V +1 07/15/26, 06:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104778

  3. Henrik Elsner voted on patch set 1 CR +1 V +1 07/15/26, 07:24

  4. Benni Mack updated the commit message in patch set 2 CR +1 V +1 07/15/26, 07:56

  5. core-ci voted on patch set 2 V +1 07/15/26, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104781

  6. Tobias Wojtylak updated the commit message in patch set 3 V +1 07/15/26, 08:38

  7. core-ci voted on patch set 3 V +1 07/15/26, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104782

  8. Henrik Elsner voted on patch set 3 CR +1 V +1 07/15/26, 09:54

  9. Benni Mack commented on patch set 4 CR +1 V +1 07/17/26, 14:46

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V +1 07/17/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104891

  11. Benni Mack voted on patch set 4 CR +1 V +1 07/17/26, 15:00

  12. Thomas Maroschik voted on patch set 4 CR +1 V +1 07/23/26, 10:57

  13. Benni Mack voted on patch set 4 CR +2 V +2 07/23/26, 11:03

  14. Benni Mack merged patch set 5 07/23/26, 11:54