94794[TASK] Deprecate StringUtility::multibyteStringPad()
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Utility/StringUtility.php+9 −26
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-110202-StringUtilityMultibyteStringPad.rstnew+58 −0
- typo3/sysext/core/Tests/Unit/Utility/StringUtilityTest.php+3 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/PaddingViewHelper.php+7 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/PaddingViewHelperTest.php+4 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+5 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+8 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 911
-
Georg Ringer uploaded patch set 1 07/15/26, 20:32
-
core-ci voted on patch set 1 V +1 07/15/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104807
-
Georg Ringer commented on patch set 1 07/15/26, 20:44
This change is ready for review. -
Benni Mack voted on patch set 1 CR +1 V +1 07/16/26, 06:16
-
Andreas Kienast commented on patch set 1 CR +1 07/16/26, 08:46
FYI, since I stumbled upon this: `mb_str_pad()` was introduced in PHP 8.3, but our composer.json requires PHP 8.2 at least. **But**: we have `symfony/polyfill-php83` in place which (hopefully properly) takes care of this. -
Benni Mack commented on patch set 1 07/16/26, 09:36
Reply
yup. plus, we want to raise our minimum requirement to PHP 8.5 for v15. -
Andreas Kienast uploaded patch set 2
CR +1V +107/29/26, 11:21 -
core-ci voted on patch set 2 V +1 07/29/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105591
-
Benni Mack voted on patch set 2 CR +1 V +1 07/29/26, 11:39
-
Andreas Kienast voted on patch set 2 CR +2 V +2 07/29/26, 11:39
-
Andreas Kienast merged patch set 3 07/29/26, 11:39