Review main Merged

94794[TASK] Deprecate StringUtility::multibyteStringPad()

Georg Ringer CR +2 V +2 Normal +101 −29 updated 07/29/26, 11:39

Commit message

The multibyte-safe padding wrapper is obsolete since PHP 8.3 ships the
native mb_str_pad(). The method is deprecated and its core callers now
use mb_str_pad() directly, guarding the empty pad string case that
mb_str_pad() rejects with a ValueError.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 911

  1. Georg Ringer uploaded patch set 1 07/15/26, 20:32

  2. core-ci voted on patch set 1 V +1 07/15/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104807

  3. Georg Ringer commented on patch set 1 07/15/26, 20:44

    This change is ready for review.
  4. Benni Mack voted on patch set 1 CR +1 V +1 07/16/26, 06:16

  5. Andreas Kienast commented on patch set 1 CR +1 07/16/26, 08:46

    FYI, since I stumbled upon this: `mb_str_pad()` was introduced in PHP 8.3, but our composer.json requires PHP 8.2 at least. **But**: we have `symfony/polyfill-php83` in place which (hopefully properly) takes care of this.
  6. Benni Mack commented on patch set 1 07/16/26, 09:36

    Reply

    yup. plus, we want to raise our minimum requirement to PHP 8.5 for v15.
  7. Andreas Kienast uploaded patch set 2 CR +1 V +1 07/29/26, 11:21

  8. core-ci voted on patch set 2 V +1 07/29/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105591

  9. Benni Mack voted on patch set 2 CR +1 V +1 07/29/26, 11:39

  10. Andreas Kienast voted on patch set 2 CR +2 V +2 07/29/26, 11:39

  11. Andreas Kienast merged patch set 3 07/29/26, 11:39