948[BUGFIX] fix t3lib_extMgm::addToAllTCAtypes(..... , 'replace:xxx')
Commit message
Review
-
Code review CR +2
- Stefan Galinski +2
- Susi Moog +1
-
Verified V +1
- Susi Moog +1
Files 2
Review log 16
-
Peter Niederlag commented on patch set 1 03/01/11, 16:14
Looks good to me, but someone else must approve looks -
Peter Niederlag commented on patch set 1 03/01/11, 16:14
Looks good to me, approved -
Peter Niederlag commented on patch set 1 03/01/11, 16:14
No score -
Peter Niederlag uploaded patch set 2 03/01/11, 16:14
-
Tolleiv Nietsch commented on patch set 2 03/01/11, 16:14
(1 inline comment) added commentBrilliant change ;) -
Susi Moog commented on patch set 1 03/01/11, 16:14
I would prefer that you didn't submit this -
Susi Moog commented on patch set 2 03/01/11, 16:14
Verified; Looks good to me, but someone else must approve -
Steffen Kamper commented on patch set 1 03/01/11, 16:14
Looks good to me, approved already tested this patch with svn and voted in core list, so go ahead. -
Steffen Kamper commented on patch set 2 03/01/11, 16:14
What's the difference to patchset1, is there a way to see that? -
Stefan Galinski commented on patch set 1 03/01/11, 16:14
Looks good to me, but someone else must approve -
Stefan Galinski commented on patch set 2 03/01/11, 16:14
Looks good to me, but someone else must approve Hi Steffen, Just open a changeset in the side-by-side diff mode and you can define the compare rule (above the options), e.g. to just show the diff between this and the last patch set. -
Stefan Galinski commented on patch set 2 03/01/11, 16:14
Hi Steffen, Just open a changeset in the side-by-side diff mode and you can define the compare rule (above the options), e.g. to just show the diff between this and the last patch set. -
Helmut Hummel commented on patch set 1 03/01/11, 16:14
I would prefer that you didn't submit this Please add a prefix to the commit message -
Fabien Udriot commented on patch set 1 03/01/11, 16:14
I would prefer that you didn't submit this As requested ;) -
Stefan Galinski commented on patch set 2 03/01/11, 16:14
Looks good to me, approved -
Stefan Galinski merged patch set 2 03/01/11, 16:14