94800[!!!][TASK] Raise minimum PHP version to 8.5
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 20
- Build/gitlab-ci/nightly/e2e-install.yml+6 −28
- Build/gitlab-ci/nightly/e2e.yml+2 −2
- Build/gitlab-ci/nightly/functional.yml+21 −21
- Build/gitlab-ci/nightly/integrity.yml+11 −14
- Build/gitlab-ci/nightly/unit.yml+8 −114
- Build/gitlab-ci/pre-merge/e2e-install.yml+6 −6
- Build/gitlab-ci/pre-merge/e2e.yml+2 −2
- Build/gitlab-ci/pre-merge/functional.yml+6 −6
- Build/gitlab-ci/pre-merge/integrity.yml+25 −26
- Build/gitlab-ci/pre-merge/unit.yml+3 −14
- Build/Scripts/phpIntegrityChecker.php+1 −1
- Build/Scripts/runTests.sh+8 −20
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110211-RaiseMinimumPHPVersionTo85.rstnew+35 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/FileUploadControllerTest.php+4 −7
- typo3/sysext/felogin/Documentation/Examples/Index.rst+0 −6
- typo3/sysext/install/Classes/Controller/UpgradeController.php+1 −1
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
- composer.json6+3 −2
- composer.lock+9 −9
Review log 2432
Show 67 earlier messages
-
Benni Mack uploaded patch set 1 07/16/26, 14:32
-
core-ci voted on patch set 1 V -1 07/16/26, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104834
-
Markus Klein commented on patch set 1 07/16/26, 19:52
Lovely! -
Markus Klein commented on patch set 1 07/16/26, 19:54
composer.json:43Is this still needed at all? -
Benni Mack commented on patch set 1 07/17/26, 09:15
composer.json:43Replysure, if a contributor does a "composer require symfony/mime:^8" it will include the PHP packages that have php 8.5.0+. This becomes increasingly important when we have PHP 8.6 and a contributor has 8.6 locally, we might run into problems. -
Andreas Kienast commented on patch set 1 07/17/26, 09:19
Please also keep nikic/php-parser in mind. Keyword here is `PhpVersion::fromComponents(8, 2)`. -
Benni Mack rebased onto patch set 2
V -107/17/26, 17:21
-
core-ci voted on patch set 2 V +1 07/17/26, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104902
-
Wouter Wolters voted on patch set 2 CR +1 V +1 07/17/26, 17:48
-
Wouter Wolters commented on patch set 2 V 0 CR -1 07/17/26, 18:02
composer.json:107These can be removed. -
core-ci voted on patch set 2 V -1 07/17/26, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104904
-
Stefan Bürk commented on patch set 2 07/21/26, 08:45
On it ... -
Stefan Bürk uploaded patch set 3
CR -1V -107/21/26, 09:50 -
Stefan Bürk commented on patch set 3 07/21/26, 09:53
composer.json:107ReplyNot sure. `symfony/validator` installs it (requires it) so it gets installed anyway. I'd leave this to a generic `symfony` components dependency raise/investigation change to determine. Okay for you ? @typo3@wouterwolters.nl -
core-ci voted on patch set 3 V +1 07/21/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105090
-
core-ci commented on patch set 3 07/21/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105091
-
Stefan Bürk uploaded patch set 4
V +107/21/26, 10:13 -
Stefan Bürk commented on patch set 4 07/21/26, 10:14
Reply
This comment was relate to TYPO3 Extension Scanner. Adjusted it there. -
Stefan Bürk uploaded patch set 5 07/21/26, 10:16
-
Stefan Bürk commented on patch set 5 07/21/26, 10:22
Reply
Done -
core-ci voted on patch set 4 V +1 07/21/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105092
-
Stefan Bürk voted on patch set 5 CR +1 V +1 07/21/26, 10:28
-
Benni Mack commented on patch set 5 07/21/26, 11:07
This change is ready for review.composer.json:107Replylet's deal with them separately. -
core-ci voted on patch set 5 V +1 07/21/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105093
-
Markus Klein commented on patch set 5 CR -1 07/21/26, 12:06
on it -
Markus Klein uploaded patch set 6
CR +1V +107/21/26, 12:14 -
Andreas Kienast commented on patch set 5 07/21/26, 12:15
composer.json:107ReplyYou can put the packages into `replace`, which is already done for some packages. -
Markus Klein voted on patch set 6 CR +1 V +1 07/21/26, 12:18
-
core-ci voted on patch set 6 V +1 07/21/26, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105098
-
Stefan Bürk voted on patch set 6 CR +1 V +1 07/21/26, 12:39
-
Benni Mack commented on patch set 6 CR +2 V +2 07/21/26, 13:50
Reply
Done -
Benni Mack merged patch set 7 07/21/26, 13:50