Review main Merged Breaking

94800[!!!][TASK] Raise minimum PHP version to 8.5

Benni Mack CR +2 V +2 Hard +153 −281 updated 07/21/26, 13:50

Commit message

TYPO3 now requires at least PHP 8.5. The composer manifests,
the Install Tool environment check, runTests.sh and all CI
stages are raised to PHP 8.5, removing obsolete job variants
for PHP 8.2, 8.3 and 8.4.

`symfony/cache-contracts` is only added as dev dependancy to
mitigate `composerInstallMin` issues in unit and functional
test executions to have lowest compat version ensured.

Used command(s):

  composer config platform.php "8.5.0" && \
    composer require 'php':'^8.5' && \
    composer require \
      -d typo3/sysext/core --no-update \
      'php':'^8.5' && \
    composer require --dev 'symfony/cache-contracts':'^3.7'

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 2432

Show 67 earlier messages
  1. Benni Mack uploaded patch set 1 07/16/26, 14:32

  2. core-ci voted on patch set 1 V -1 07/16/26, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104834

  3. Markus Klein commented on patch set 1 07/16/26, 19:52

    Lovely!
  4. Markus Klein commented on patch set 1 07/16/26, 19:54

    composer.json:43

    Is this still needed at all?
  5. Benni Mack commented on patch set 1 07/17/26, 09:15

    composer.json:43 Reply

    sure, if a contributor does a "composer require symfony/mime:^8" it will include the PHP packages that have php 8.5.0+. This becomes increasingly important when we have PHP 8.6 and a contributor has 8.6 locally, we might run into problems.
  6. Andreas Kienast commented on patch set 1 07/17/26, 09:19

    Please also keep nikic/php-parser in mind. Keyword here is `PhpVersion::fromComponents(8, 2)`.
  7. Benni Mack rebased onto patch set 2 V -1 07/17/26, 17:21

  1. core-ci voted on patch set 2 V +1 07/17/26, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104902

  2. Wouter Wolters voted on patch set 2 CR +1 V +1 07/17/26, 17:48

  3. Wouter Wolters commented on patch set 2 V 0 CR -1 07/17/26, 18:02

    composer.json:107

    These can be removed.
  4. core-ci voted on patch set 2 V -1 07/17/26, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104904

  5. Stefan Bürk commented on patch set 2 07/21/26, 08:45

    On it ...
  6. Stefan Bürk uploaded patch set 3 CR -1 V -1 07/21/26, 09:50

  7. Stefan Bürk commented on patch set 3 07/21/26, 09:53

    composer.json:107 Reply

    Not sure. `symfony/validator` installs it (requires it) so it gets installed anyway. I'd leave this to a generic `symfony` components dependency raise/investigation change to determine. Okay for you ? @typo3@wouterwolters.nl
  8. core-ci voted on patch set 3 V +1 07/21/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105090

  9. core-ci commented on patch set 3 07/21/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105091

  10. Stefan Bürk uploaded patch set 4 V +1 07/21/26, 10:13

  11. Stefan Bürk commented on patch set 4 07/21/26, 10:14

    Reply

    This comment was relate to TYPO3 Extension Scanner. Adjusted it there.
  12. Stefan Bürk uploaded patch set 5 07/21/26, 10:16

  13. Stefan Bürk commented on patch set 5 07/21/26, 10:22

    Reply

    Done
  14. core-ci voted on patch set 4 V +1 07/21/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105092

  15. Stefan Bürk voted on patch set 5 CR +1 V +1 07/21/26, 10:28

  16. Benni Mack commented on patch set 5 07/21/26, 11:07

    This change is ready for review.

    composer.json:107 Reply

    let's deal with them separately.
  17. core-ci voted on patch set 5 V +1 07/21/26, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105093

  18. Markus Klein commented on patch set 5 CR -1 07/21/26, 12:06

    on it
  19. Markus Klein uploaded patch set 6 CR +1 V +1 07/21/26, 12:14

  20. Andreas Kienast commented on patch set 5 07/21/26, 12:15

    composer.json:107 Reply

    You can put the packages into `replace`, which is already done for some packages.
  21. Markus Klein voted on patch set 6 CR +1 V +1 07/21/26, 12:18

  22. core-ci voted on patch set 6 V +1 07/21/26, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105098

  23. Stefan Bürk voted on patch set 6 CR +1 V +1 07/21/26, 12:39

  24. Benni Mack commented on patch set 6 CR +2 V +2 07/21/26, 13:50

    Reply

    Done
  25. Benni Mack merged patch set 7 07/21/26, 13:50