Review main Merged

94801[BUGFIX] Prevent multiple identifier quoting in new Extbase QoM methods

Garvin Hicking CR +2 V +2 Normal +36 −22 updated 07/17/26, 20:48

Commit message

The new ``trim`/`concat`/`coalesce` methods introduced
in #32051 for `order by` sections wrongly returned identifiers,
quoted multiple times.

This is now fixed be ensuring the proper queryBuilder object gets
these identifiers for quoting order.

Tests are adapted to make stricter expectations that will now catch
this wrong quoting, which was too lax previously.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Garvin Hicking uploaded patch set 1 07/16/26, 18:23

  2. Garvin Hicking marked it work in progress 07/16/26, 18:30

  3. core-ci voted on patch set 1 V +1 07/16/26, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104837

  4. Garvin Hicking updated the commit message in patch set 2 V +1 07/16/26, 18:50

  5. Garvin Hicking marked it ready for review 07/16/26, 18:51

  6. core-ci voted on patch set 2 V +1 07/16/26, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104838

  7. Oliver Klee voted on patch set 2 V +1 07/16/26, 21:05

  8. Benni Mack voted on patch set 2 CR +1 V +1 07/17/26, 16:31

  9. Garvin Hicking voted on patch set 2 CR +2 V +2 07/17/26, 20:32

  10. Garvin Hicking merged patch set 3 07/17/26, 20:48