Review main Merged

94802[TASK] Avoid duplicate code for USER_INT placeholder

Markus Klein CR +2 V +2 Easy +20 −25 updated 08/01/26, 07:20

Commit message

Merge the duplicate code of USER_INT and EXTBASEPLUGIN into a single method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Markus Klein uploaded patch set 1 07/16/26, 19:41

  2. core-ci voted on patch set 1 V -1 07/16/26, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104839

  3. Benni Mack commented on patch set 1 07/17/26, 11:31

    AbstractContentObject.php:73

    subclasses only type-int this as an array, however, you enforce it in this place with a concrete PHP type "array". please cast this in the calls on the subclasses,
  4. Markus Klein uploaded patch set 2 V -1 07/30/26, 16:06

  5. Markus Klein commented on patch set 2 07/30/26, 16:07

    This change is ready for review.

    AbstractContentObject.php:73 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 V +1 07/30/26, 16:14

  7. core-ci voted on patch set 2 V -1 07/30/26, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105703

  8. Wouter Wolters uploaded patch set 3 CR +1 V +1 07/30/26, 17:45

  9. Wouter Wolters voted on patch set 3 CR +1 07/30/26, 17:46

  10. core-ci voted on patch set 3 V +1 07/30/26, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105707

  11. Benni Mack voted on patch set 3 CR +2 V +2 08/01/26, 07:20

  12. Benni Mack merged patch set 4 08/01/26, 07:20