Review main Merged

94806[TASK] Test against latest RDBMS versions

Benni Mack CR +2 V +2 Easy +12 −12 updated 07/21/26, 08:44

Commit message

runTests.sh accepts MariaDB up to 11.8 (LTS) and PostgreSQL
17 and 18 for the -i option since #110240; MySQL 8.4 (LTS)
is already included. Related fixes has been already added
with #110234 and #110241.

The nightly "max" jobs of the functional and e2e-install
suites are bumped from MariaDB 10.10, MySQL 8.0 and
PostgreSQL 15 to MariaDB 11.8, MySQL 8.4 and PostgreSQL 18,
so the newest DBMS versions are covered continuously. The
"min" jobs keep running the oldest supported versions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Markus Klein +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 4

Files 2

Review log 2126

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 07/17/26, 09:40

  1. core-ci voted on patch set 1 V +1 07/17/26, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104869

  2. Benni Mack marked it ready for review 07/17/26, 17:21

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 07/17/26, 17:52

  4. Oliver Klee voted on patch set 1 CR +1 V +1 07/18/26, 09:22

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 07/18/26, 16:52

  6. Markus Klein voted on patch set 1 CR +1 07/18/26, 18:10

  7. Markus Klein commented on patch set 1 07/18/26, 18:13

    for v15, shouldn't we drop any non-supported DB version as we do with PHP? I mean, even MySQL 8.4 is old already, but the only supported version in 8.x
  8. Benni Mack commented on patch set 1 07/19/26, 06:54

    Reply

    we can remove them AFAIK (= separate breaking change) once we upgrade to Doctrine DBAL 5 (https://github.com/doctrine/dbal/blob/5.0.x/UPGRADE.md#bc-break-removed-support-for-mariadb-104--105-mysql-57-and-postgres-10--11)
  9. Markus Klein commented on patch set 1 07/19/26, 14:03

    Reply

    ✔️
  10. core-ci voted on patch set 1 V -1 07/19/26, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104972

  11. Stefan Bürk commented on patch set 1 CR -2 07/19/26, 21:25

    Sorry to block this. I really must say that I wonder about the `+1 testing` votes here. `MariaDB >= 11` is not supported yet (and that for reason), communicated and stated a lot already even for older versions. I executed a nightly run on this change (which executes the new version matrix) and the result speaks for itself. Some more details for current main: ``` | MariaDB | In CI? | Elevated? | Result | |----------------|----------------------|-----------|----------------------------------------| | 10.4 | **yes** (nightly) | yes | **OK** — 0 failures | | 10.10 | **yes** (nightly) | yes | not re-run (CI green) | | 10.11 | no | yes | **OK** — 0 failures | | 11.0 | no | yes | **OK** — 0 failures | | 11.1 | no | yes | **OK** — 0 failures | | 11.2 | no | yes | **OK** — 0 failures | | 11.3 | no | yes | **OK** — 0 failures | | **11.4** (LTS) | no | **yes** | **20 failures** ← first broken version | | **11.8** (LTS) | no (not expressible) | **no** | 2 errors + 6 failures | ``` The same counts for Postgres 16+. Older TYPO3 version the same. Can't remember when I enhanced the database testing (v12 or v13) but that there we did not had the platform overrides (v12) and the tests, but v13 already had failing tests for MariaDB 11+ and the reason we never communicated it as supported officially. We need to work on that first before stating it as supported. The MariaDB 11+ is allowed in `runTests.sh` so it can be executed locally - but I (and noone else) ever picked up to work on it and the support. I have created a list of things to work on the doctrine/dbal regarding deprecation and support and going to work on it. If at all I would say that we should first only allow additional dbms versions for postgres, MariaDB and similar but not adding it to the CI test matrix. Secondly, regarding the discussion about "dropping" support. Yes, we should talk about that (for main) to raise them matching "lowest" supported version of Doctrine DBAL 5 as preparation. Resolving deprecation and the upgrade requires quite some work anyway - and until now it is not clear when dbal5 will really be released. My last "answer" I recieved was maybe end of 2026 or 2027 - we do not have a release date for it right now. Did not rechecked that in the last couple of months (since February) - just to be honest. @benni@typo3.org let's coordinate on that and how to proceed here. My plan was to address dbal 4.x deprecation first (main, 14.3, 13.4), work on the platform overrides (moving it more into dbal directly + finishing dbal bugfix and to have it dbal released which requires adjustment on our side on dbal raise than - have the one or other pending wip change for that). Additionally, I want to get rid of the platform overrides which requires also work on upstream dbal first making upcoming platform support easier again in the future. Also missing is a upstream bugfix for SQLite and database compare or some hacky solution. All of that requries time and coordination. I'll try to work on that the next time but heavily depends than on review power (and upstream releases).
  12. Stefan Bürk commented on patch set 1 07/20/26, 08:47

    Reply

    First prefix: * 94843: [BUGFIX] Fix table option lookup on MariaDB 11.4+ | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94843
  13. Benni Mack commented on patch set 1 CR -2 07/20/26, 11:22

    will push a pre-change for the runTests.sh
  14. Stefan Bürk uploaded patch set 2 CR +1 V +1 07/20/26, 19:35

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. Stefan Bürk updated the commit message in patch set 3 07/20/26, 19:38

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  16. core-ci voted on patch set 2 V +1 07/20/26, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105043

  17. core-ci voted on patch set 3 V +1 07/20/26, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105044

  18. Stefan Bürk commented on patch set 3 CR 0 07/20/26, 19:49

    Reply

    Second: 94851: [TASK] Extend runTests.sh database version matrix | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94851 Third: 94852: [BUGFIX] Elevate new MariaDB and Postgres platforms | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94852 and rebased this change on top of these two changes. Going to start nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/105045
  19. core-ci commented on patch set 3 07/20/26, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105045

  20. Stefan Bürk commented on patch set 3 CR +1 V +1 07/20/26, 20:05

    Reply

    And happy (green).
  21. Benni Mack voted on patch set 3 CR 0 07/21/26, 06:43

  22. Garvin Hicking commented on patch set 3 CR +1 V +1 07/21/26, 08:18

    Reply

    Done
  23. Stefan Bürk voted on patch set 3 CR +2 V +2 07/21/26, 08:19

  24. Markus Klein voted on patch set 3 CR +1 07/21/26, 08:34

  25. Stefan Bürk merged patch set 4 07/21/26, 08:44