Review main Merged

94821[BUGFIX] Make LogRecord writeable ArrayAccess / offsetSet

Benni Mack CR +2 V +2 Easy +1 −1 updated 07/17/26, 18:28

Commit message

While trying to make LogRecord immutable, the original
code + author in 2010 actually implemented offsetSet()
the wrong way, never allowing to set custom values via
a LogProcessor.

The no-brainer is fixed, even though apparantly
it was never used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 07/17/26, 17:32

  2. Wouter Wolters voted on patch set 1 CR +1 V +1 07/17/26, 17:33

  3. core-ci voted on patch set 1 V +1 07/17/26, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104903

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 07/17/26, 18:25

  5. Benni Mack voted on patch set 1 CR +2 V +2 07/17/26, 18:28

  6. Benni Mack merged patch set 2 07/17/26, 18:28