Review main Abandoned Breaking

94830[WIP][!!!][TASK] Remove SingletonInterface from core classes

Stefan Bürk CR 0 V -1 Hard +745 −240 updated 09/01/26, 12:16

Commit message

The marker interface \TYPO3\CMS\Core\SingletonInterface is deprecated
and removed from all TYPO3 Core classes. Its two historic purposes -
implicit public and shared service registration, and process-wide
singleton caching in GeneralUtility::makeInstance() - are nowadays
covered by the dependency injection container itself.

Classes that are retrieved by class name via makeInstance() now declare
their public visibility explicitly through Symfony's Autoconfigure
attribute. Groups of related classes that share a common interface are
kept public transparently by registering that interface for
autoconfiguration: RepositoryInterface, TypeConverterInterface and
PageTitleProviderInterface.

A few services that were only public implicitly through the marker, but
are never retrieved by class name within Core, are no longer public:
DataProviderCollection, Scheduler and the Extbase ConfigurationManager
(depend on the public ConfigurationManagerInterface instead). Core call
sites retrieving the configuration manager by name now use the
interface. The EventDispatcher stays public through its
EventDispatcherInterface alias.

The GeneralUtility test helpers setSingletonInstance(),
removeSingletonInstance(), resetSingletonInstances() and
getSingletonInstances() are deprecated alongside the interface. The
backwards-compatibility machinery keeps working throughout v15; the
interface, the helpers and the SingletonPass are removed in v16.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 113

Show 93 more files

Review log 47

  1. Stefan Bürk uploaded patch set 1 07/18/26, 00:45

  2. Stefan Bürk updated the commit message in patch set 2 07/18/26, 00:47

  3. core-ci voted on patch set 1 V -1 07/18/26, 00:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104920

  4. core-ci voted on patch set 2 V -1 07/18/26, 00:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104921

  5. Stefan Bürk uploaded patch set 3 V -1 07/18/26, 18:21

  6. core-ci voted on patch set 3 V -1 07/18/26, 18:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104941

  7. Stefan Bürk abandoned the change 09/01/26, 12:16

    Benni worked on that epic in multiple steps, this is really outdated and refreshing does not make much sense.