Review main Merged

94838[TASK] Improve dashboard DTO types

Benjamin Franzke CR +2 V +2 Normal +53 −29 updated 09/02/26, 10:07

Commit message

Add statically analyzable types for dashboard transfer objects
and use the WidgetPosition DTO that was introduced in #103453,
but was missed to be used right away.
This allows phpstan to find typos when parameters are used
and will allow to create a respective schema in future.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1316

  1. Benjamin Franzke uploaded patch set 1 07/20/26, 06:51

  2. core-ci voted on patch set 1 V +1 07/20/26, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105005

  3. Benjamin Franzke rebased onto patch set 2 V +1 08/27/26, 08:50

  4. core-ci voted on patch set 2 V +1 08/27/26, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107228

  5. Georg Ringer voted on patch set 2 CR +1 V +1 08/27/26, 15:49

  6. Wouter Wolters voted on patch set 2 CR +1 V +1 08/27/26, 20:38

  7. Benjamin Franzke commented on patch set 2 CR -1 08/28/26, 09:09

    WidgetPositions.php:24

    remark from Benji: Check if we can add generic collections instead
  8. Benjamin Franzke uploaded patch set 3 CR +1 V +1 08/31/26, 08:13

  9. Benjamin Franzke commented on patch set 3 08/31/26, 08:13

    WidgetPositions.php:24 Reply

    Removed for now, used `array<string, list<WidgetPosition>>` instead and ensured object serialization in `Dto/Dashboard`.
  10. core-ci voted on patch set 3 V +1 08/31/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107388

  11. Benjamin Franzke wrote 08/31/26, 08:52

    Hashtag added: actions
  12. Benni Mack voted on patch set 3 CR +1 09/02/26, 09:20

  13. Georg Ringer voted on patch set 3 CR +1 V +1 09/02/26, 09:25

  14. Benjamin Kott voted on patch set 3 CR +1 V +1 09/02/26, 09:49

  15. Benjamin Franzke voted on patch set 3 CR +2 V +2 09/02/26, 10:07

  16. Benjamin Franzke merged patch set 4 09/02/26, 10:07