Review main Merged

94839[TASK] Add search query data to `AfterPageTreeItemsPreparedEvent`

Benjamin Franzke CR +2 V +2 Normal +67 −40 updated 08/31/26, 09:02

Commit message

Consumers of the `AfterPageTreeItemsPreparedEvent` are currently
required to postprocess the page tree items based on implementation
specific GET parameters which need to be retrieved directly from the
request object.

In order to provide a clear API that is independant from a shallow
request object, the search data is now explicitly added to the
`AfterPageTreeItemsPreparedEvent` and used by the respective
consumers of this event.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 07/20/26, 07:00

  2. core-ci voted on patch set 1 V +1 07/20/26, 07:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105006

  3. Stefan Bürk commented on patch set 1 07/23/26, 10:34

    AfterPageTreeItemsPreparedEvent.php:41

    Maybe only nit-pik, but personally I find the nameing confusing or at least error prone. The value is the `search phrase` (only the `q`) and maybe we should us that naming here to emphasize the use case ? (property, getter). What do you think ? Side note: I guess adding a `important` restfile stating the new handling and the planned outcome to shift more to concreate values and dropping the `$request` to communicate the long-term plan would make sense ? To make this sure, I wanted to through this only in as discussion and not as a blocker right now and hope that is okay.
  4. Stefan Bürk commented on patch set 1 07/23/26, 10:43

    AfterPageTreeItemsPreparedEvent.php:41 Reply

    throw (not through)
  5. Benjamin Franzke uploaded patch set 2 V +1 08/27/26, 08:47

  6. Benjamin Franzke commented on patch set 2 08/27/26, 08:47

    AfterPageTreeItemsPreparedEvent.php:41 Reply

    Thank you, done: Switched to `getSearchQuery()` and added an Important.rst.
  7. core-ci voted on patch set 2 V +1 08/27/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107227

  8. Georg Ringer voted on patch set 2 CR +1 V +1 08/27/26, 10:15

  9. Benjamin Kott voted on patch set 2 CR +1 V +1 08/28/26, 09:14

  10. Benjamin Franzke voted on patch set 2 CR +2 V +2 08/31/26, 06:50

  11. Benjamin Franzke merged patch set 3 08/31/26, 06:50

  12. Benjamin Franzke wrote 08/31/26, 09:02

    Hashtag added: actions