Review 14.3 Merged

94840[BUGFIX] Preserve route target when MFA intercepts a route request

Benjamin Franzke CR +2 V +2 Easy +6 −1 updated 09/07/26, 10:52

Commit message

…that is not the login route.

`RouteRedirect` has two factories:

 * `createFromRequest()` – intended to handle
   cases where `/typo3/login?redirect={routeTarget}`
   is used, that means the route redirect target is
   wrapped into the login route
 * `createFromRoute()` – intended to be used
   when /typo3/module/foobar is requested

Both cases can occur when user authentication gets intercepted because second factor authentication has not yet been performed.

Only the first was handled until now, because MFA *usually* intercepts
the login controller, but the second case happens when the second factor
step is aborted and restarted later on (e.g. 2FA tab was closed and the
target link was reopened again).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 610

  1. Benjamin Franzke uploaded patch set 1 07/20/26, 07:03

  2. core-ci voted on patch set 1 V -1 07/20/26, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105007

  3. Benjamin Franzke uploaded patch set 2 V -1 07/21/26, 07:57

  4. core-ci voted on patch set 2 V +1 07/21/26, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105084

  5. Benjamin Franzke uploaded patch set 3 V +1 09/07/26, 07:50

  6. core-ci voted on patch set 3 V -1 09/07/26, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107984

  7. Benjamin Franzke uploaded patch set 4 V -1 09/07/26, 09:40

  8. core-ci voted on patch set 4 V +1 09/07/26, 09:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107993

  9. Benjamin Franzke commented on patch set 4 CR +2 V +2 09/07/26, 10:26

    This change is ready for review.
  10. Benjamin Franzke merged patch set 5 09/07/26, 10:52