Review 14.3 Merged

94862[BUGFIX] Do not break fixed positioning inside modals

Benjamin Kott CR +2 V +2 Normal +60 −32 updated 07/21/26, 14:42

Commit message

Elements inside a modal that use "position: fixed" were positioned
against the modal instead of the viewport, and moved along while the
modal was opening or closing.

The modal animated its slide with a CSS transform. An element carrying a
transform becomes the containing block for all descendants using
"position: fixed", which changes what their coordinates refer to. Since
the transform was animated, that reference box kept moving for the
duration of the animation.

The slide is now animated with the inset properties, which move the
modal without establishing a containing block. The distance can be
adjusted via "--typo3-modal-slide".

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Kott commented on patch set 1 07/21/26, 14:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/21/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105106

  3. Benjamin Kott voted on patch set 1 CR +2 V +2 07/21/26, 14:42

  4. Benjamin Kott merged patch set 2 07/21/26, 14:42