94863[!!!][TASK] Remove implicit output buffering from Bootstrap
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Console/CommandApplication.php+7 −2
- typo3/sysext/core/Classes/Core/Bootstrap.php2+0 −14
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110250-RemovedImplicitOutputBufferingFromBootstrap.rst2new+62 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/install/Tests/Functional/Http/ApplicationFailedLoginEmailTest.php+4 −2
Review log 1319
-
Benni Mack uploaded patch set 1 07/21/26, 15:08
-
core-ci voted on patch set 1 V -1 07/21/26, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105107
-
Stefan Bürk uploaded patch set 2
V -107/23/26, 16:45 -
core-ci voted on patch set 2 V -1 07/23/26, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105259
-
Stefan Bürk uploaded patch set 3
V -107/23/26, 17:01 -
core-ci voted on patch set 3 V +1 07/23/26, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105260
-
Stefan Bürk uploaded patch set 4
V +107/23/26, 17:53 -
core-ci voted on patch set 4 V +1 07/23/26, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105263
-
Stefan Bürk uploaded patch set 5
V +107/23/26, 18:17 -
Stefan Bürk commented on patch set 5 07/23/26, 18:24
The change does more than the subject advertises. Besides removing the output buffer it also (a) reorders `checkEncryptionKey()` relative to `ext_localconf` loading, (b) moves the `$GLOBALS['TCA']` assignment to after `TcaSchemaFactory::load()`, and (c) adds `declare(strict_types=1)` plus constructor-promotion / return-type hardening in `MiddlewareDispatcher`, `AbstractApplication` and `install/Classes/Http/Application`. The type-hardening is unrelated cleanup and would be much easier to review as its own [TASK]. At minimum the behaviour change in (a) needs a changelog paragraph.Bootstrap.php:150`checkEncryptionKey()` now runs *before* `ExtLocalconfFactory::load()`; before this change it ran afterwards (and after `$GLOBALS['TCA']` was populated). Installations that set `$GLOBALS['TYPO3_CONF_VARS']['SYS']['encryptionKey']` from `ext_localconf.php` — a real, if discouraged, deployment pattern — used to satisfy the check, but now hit the "TYPO3 Encryption Key is empty" exception before their `ext_localconf.php` is even loaded. That is a behaviour change beyond "remove output buffering" and is not covered by the changelog. Is the reordering intended? If so it deserves its own note in the Breaking changelog.Breaking-110250-RemovedImplicitOutputBufferingFromBootstrap.rst:64`NotScanned` undersells the removals here: three of the four removed methods are `public static`, and the "Affected installations" section explicitly says third-party / custom bootstrap scripts call them. `Bootstrap::populateLocalConfiguration` already has an ExtensionScanner matcher (`install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php:743`), but `startOutputBuffering()`, `baseSetup()` and `createConfigurationManager()` have none. Either add matchers for the three and drop `NotScanned`, or add a short justification for why they stay unscanned. -
core-ci voted on patch set 5 V +1 07/23/26, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105264
-
Benni Mack uploaded patch set 6
V +107/29/26, 09:28 -
Benni Mack commented on patch set 6 07/29/26, 09:29
This change is ready for review.Reply
DoneBootstrap.php:150ReplyDoneBreaking-110250-RemovedImplicitOutputBufferingFromBootstrap.rst:64ReplyDone -
core-ci voted on patch set 6 V +1 07/29/26, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105577
-
Stefan Bürk voted on patch set 6 CR +1 V +1 07/29/26, 10:01
-
Jochen Roth voted on patch set 6 CR +1 V +1 07/29/26, 11:14
-
Benni Mack voted on patch set 6 CR +2 V +2 07/29/26, 11:18
-
Benni Mack merged patch set 7 07/29/26, 11:18
-
Benjamin Franzke commented on patch set 7 07/31/26, 09:20
Followup: > 91383: [TASK] Followup on output buffering removal | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91383