Review main Merged

94869[TASK] Avoid deprecated Doctrine DBAL identifier quoting

Stefan Bürk CR +2 V +2 Easy +10 −1 updated 07/22/26, 16:50

Commit message

Doctrine DBAL 4.4 deprecated `Connection::quoteIdentifier()` and
`AbstractPlatform::quoteIdentifier()`, both are removed with
Doctrine DBAL 5.0. Callers should quote each part of a qualified
name with `quoteSingleIdentifier()` instead. [1]

`TYPO3\CMS\Core\Database\Connection::quoteIdentifier()` delegated
to the deprecated parent implementation, which itself called the
deprecated platform method - emitting two deprecations per call.

Being the funnel of the public quoting API, this is the most
frequently reached deprecated Doctrine DBAL call in TYPO3.
`QueryBuilder::quoteIdentifier()`, `Connection::quoteIdentifiers()`
and `Connection::quoteColumnValuePairs()` all end up here, as does
any extension using them.

The parent implementation is inlined instead: qualified names are
split on the dot, each part is quoted using the platform method
`quoteSingleIdentifier()`, and the parts are joined again. That is
the method the removed implementation used internally, and the one
platforms override to provide their delimiting style. No platform
overrides `quoteIdentifier()` itself, making this change
behaviour-preserving.

[1] https://github.com/doctrine/dbal/pull/6590

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Stefan Bürk uploaded patch set 1 07/21/26, 20:18

  2. Stefan Bürk wrote 07/21/26, 20:19

    Topic set to doctrine-dbal
  3. core-ci voted on patch set 1 V +1 07/21/26, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105117

  4. Benni Mack voted on patch set 1 CR +1 V +1 07/22/26, 06:54

  5. Oliver Klee voted on patch set 1 CR +1 V +1 07/22/26, 07:36

  6. Wouter Wolters voted on patch set 1 CR +1 07/22/26, 16:13

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 07/22/26, 16:32

  8. Stefan Bürk merged patch set 2 07/22/26, 16:50