Review main Merged

94872[TASK] Clean up unit test mock platforms for Doctrine DBAL

Stefan Bürk CR +2 V +2 Normal +11 −101 updated 07/24/26, 09:46

Commit message

The unit test mock platforms below `core/Tests/Unit/Database/Mocks/`
carry leftovers from Doctrine DBAL 3.

All five mock platforms override `getReservedKeywordsClass()`,
returning `MockKeywordList`. Doctrine DBAL 4 replaced that method
with the abstract `createReservedKeywordsList()`, returning a
`KeywordList` instance instead of a class name. It no longer exists
in `AbstractPlatform`, making the five overrides dead code and
`MockKeywordList` unused - `MockPlatform` already implements
`createReservedKeywordsList()` using an anonymous class. Both are
removed, while `createReservedKeywordsList()` stays as it is
`abstract protected` in Doctrine DBAL 4.4.

Doctrine DBAL 4.4 further deprecated constructing an
`AbstractPlatform` without passing `$unquotedIdentifierFolding` [1],
triggering at runtime. Of the five mocks only `MockPlatform` is
affected, extending `AbstractPlatform` directly, while the others
extend concrete TYPO3 platforms passing the value already.

`MockPlatform` receives an explicit constructor passing
`UnquotedIdentifierFolding::UPPER`, the standard SQL behaviour and
the value Doctrine falls back to when the argument is omitted. The
parameter stays optional, keeping existing instantiations working.

Test fixtures only, no production code involved.

[1] https://github.com/doctrine/dbal/pull/6823

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 89

  1. Stefan Bürk uploaded patch set 1 07/21/26, 20:18

  2. Stefan Bürk wrote 07/21/26, 20:19

    Topic set to doctrine-dbal
  3. core-ci voted on patch set 1 V +1 07/21/26, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105120

  4. Oliver Klee voted on patch set 1 V +1 07/22/26, 07:38

  5. Wouter Wolters voted on patch set 1 CR +1 07/22/26, 16:14

  6. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/22/26, 18:22

  7. Benni Mack voted on patch set 1 CR +1 V +1 07/24/26, 07:14

  8. Stefan Bürk voted on patch set 1 CR +2 V +2 07/24/26, 09:00

  9. Stefan Bürk merged patch set 2 07/24/26, 09:46