94874[TASK] Upgrade to PHPUnit 13
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 164
- Build/phpunit/FunctionalTests.xml+2 −2
- Build/phpunit/UnitTests.xml+2 −2
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+2 −0
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Configuration/BackendUserConfigurationTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Configuration/TranslationConfigurationProviderTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/ContentElement/NewContentElementControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/SuggestWizardControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/AbstractLinkBrowserControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php2+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/SiteConfigurationControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/SiteSettingsControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Controller/SwitchUserControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/AbstractFormElementTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/ImageManipulationElementTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+2 −0
Show 144 more files
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteResolvingTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+11 −11
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+15 −15
- typo3/sysext/backend/Tests/Unit/Form/Processor/SelectItemProcessorTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/LoginProvider/LoginProviderResolverTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Error/ProductionExceptionHandlerTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Resource/ResourceFactoryTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+2 −0
- typo3/sysext/core/Tests/Functional/SystemResource/Publishing/DefaultResourcePublisherTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+10 −8
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Command/Descriptor/TextDescriptorTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php+2 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+4 −2
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+2 −0
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Error/DebugExceptionHandlerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+2 −0
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+2 −0
- typo3/sysext/core/Tests/Unit/FormProtection/InstallToolFormProtectionTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Http/MiddlewareStackResolverTest.php+4 −4
- typo3/sysext/core/Tests/Unit/LinkHandling/FolderLinkHandlerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Locking/FileLockStrategyTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Locking/LockFactoryTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Log/Processor/IntrospectionProcessorTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Package/AbstractServiceProviderTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+2 −0
- typo3/sysext/core/Tests/Unit/PasswordPolicy/Validator/CorePasswordValidatorTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Resource/Index/IndexerTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Helpers/VimeoHelperTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Service/DependencyOrderingServiceTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Session/UserSessionManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Visitor/AstConstantCommentVisitorTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Utility/CommandUtilityTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+2 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+2 −0
- typo3/sysext/dashboard/Tests/Unit/DependencyInjection/DashboardWidgetPassTest.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/Routing/UriBuilderTest.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/CollectionValidatorTest.php+2 −0
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentsTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+15 −13
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/DateTimeConverterTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Controller/UploadExtensionFileControllerTest.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/ExtensionRepositoryTest.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Parser/ExtensionXmlParserTest.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Report/ExtensionStatusTest.php+12 −10
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+6 −4
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+2 −0
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+2 −0
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+2 −0
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php+2 −0
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php+2 −0
- typo3/sysext/filelist/Tests/Unit/FileListTest.php+2 −0
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+2 −0
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinitionValidationServiceTest.php+2 −0
- typo3/sysext/form/Tests/Functional/Domain/Runtime/FormRuntimeTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatableFormElementPropertiesValidatorTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinition/Validators/CreatablePropertyCollectionElementPropertiesValidatorTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Factory/ArrayFormFactoryTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+13 −13
- typo3/sysext/form/Tests/Unit/Domain/Finishers/ClosureFinisherTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/SaveToDatabaseFinisherTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/FormElements/FileUploadTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Domain/Renderable/RenderableVariantTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/YamlSourceTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Service/CleanupFormUploadsServiceTest.php+2 −0
- typo3/sysext/form/Tests/Unit/Service/FormEditorEnrichmentServiceTest.php+2 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ImageContentObjectTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/Typolink/LinkVarsCalculatorTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/Typolink/PageLinkBuilderTest.php+2 −0
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+2 −0
- typo3/sysext/install/Tests/Functional/Service/EnableFileServiceTest.php+2 −0
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkOrDirectoryNodeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php+2 −0
- typo3/sysext/install/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+2 −0
- typo3/sysext/install/Tests/Unit/Service/CoreUpdateServiceTest.php+2 −0
- typo3/sysext/lowlevel/Tests/Functional/Controller/QuerySearchControllerTest.php+2 −0
- typo3/sysext/lowlevel/Tests/Unit/Controller/QuerySearchControllerTest.php+2 −0
- typo3/sysext/opendocs/Tests/Unit/Domain/Repository/OpenDocumentRepositoryTest.php+2 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+2 −0
- typo3/sysext/rte_ckeditor/Tests/Functional/Form/Element/RichTextElementTest.php+2 −0
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+2 −0
- typo3/sysext/seo/Tests/Unit/HrefLang/HrefLangGeneratorTest.php+2 −0
- typo3/sysext/seo/Tests/Unit/MetaTag/OpenGraphMetaTagManagerTest.php+2 −0
- typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.php+2 −0
- typo3/sysext/seo/Tests/Unit/XmlSitemap/RecordsXmlSitemapDataProviderTest.php+2 −0
- composer.json+1 −2
- composer.lock+497 −343
Review log 3753
Show 1928 earlier messages
-
Wouter Wolters uploaded patch set 1 07/21/26, 20:51
-
core-ci voted on patch set 1 V -1 07/21/26, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105126
-
Wouter Wolters uploaded patch set 2
V -107/22/26, 15:15 -
core-ci voted on patch set 2 V +1 07/22/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105188
-
Wouter Wolters updated the commit message in patch set 3
V +107/22/26, 16:06 -
Wouter Wolters marked it ready for review 07/22/26, 16:06
-
core-ci voted on patch set 3 V +1 07/22/26, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105190
-
Garvin Hicking updated the commit message in patch set 4
V +107/22/26, 16:41 -
Garvin Hicking commented on patch set 4 07/22/26, 16:43
Thanks for putting effort into this! I was planning to look at this for about a year now.... :-D I have used Claude Opus to create a commit message. I have not manually verified this yet. Prompt: The commit 50674c879a73736b1d73c93e5870afe07e67d097 in this repository introduces an update to PHPUnit 13. The commit message is too sparse. Go through all changes and see which kinds of fixes were made. Many of them seem to deal with stub/mock replacements. Go through each change and create a list of changes, which can act as a better commit message. Just use normal text indentation and bullet points, no ASCII tables. Keep the changes concise, and every single change in the end must fit into the list you made. Make no mistakes. -
Wouter Wolters commented on patch set 4 07/22/26, 16:47
Reply
Thanks, as you can see at my latest work for TYPO3 more than a year ago I was already trying to update to PHPUnit 12. Did all the prepartions for it etc. But I needed the PHP raise to at least PHP 8.3, that is now the case with PHP 8.5. I coordinated this already with Lolli and Benni for a while :) -
core-ci voted on patch set 4 V +1 07/22/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105194
-
Simon Schaufelberger commented on patch set 4 CR +1 V +1 07/22/26, 18:18
Reply
Did you use Rector or did you do everything by hand? Rector has lots of rules to automate phpunit migrations if you don't know -
Garvin Hicking commented on patch set 4 07/22/26, 20:55
(running a nightly on this now) -
core-ci commented on patch set 4 07/22/26, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105197
-
Wouter Wolters commented on patch set 4 07/22/26, 21:35
Reply
Rector was used but that did not cover everything. Lots of notices had to do with dataproviders and wrong count of function parameters. 3 expected but 4 given for example. So it is as combination of Rector, AI and my own work. -
Andreas Kienast commented on patch set 4 CR -1 07/23/26, 04:50
Sorry for being a party pooper here. Instead of using the `AllowMockObjectsWithoutExpectations` attribute I'd prefer to replace affected mocks with stubs. This works for me at least in `StateUtilityTest`. -
Garvin Hicking commented on patch set 4 07/23/26, 05:04
Reply
Done -
Benjamin Franzke commented on patch set 4 07/23/26, 07:30
FormInlineAjaxControllerTest.php:61It seems like `AllowMockObjectsWithoutExpectations` and migration from `createMock` to `createStub` was mixed and this class. It seems that `AllowMockObjectsWithoutExpectations` is probably no longer needed here, right? I guess this was lost during migration. I'd vote for splitting this patch, e.g. migrate all applicable cases to `createStub()` first, since this can easily done beforehand and eases the review a lot. -
Wouter Wolters commented on patch set 4 07/23/26, 18:44
-
Wouter Wolters marked it work in progress 07/29/26, 16:38
-
Wouter Wolters uploaded patch set 5
CR +1V +107/29/26, 16:38 -
core-ci voted on patch set 5 V -1 07/29/26, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105628
-
Wouter Wolters uploaded patch set 6
V -107/29/26, 17:05 -
core-ci voted on patch set 6 V -1 07/29/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105629
-
Wouter Wolters uploaded patch set 7
V -107/29/26, 18:25 -
core-ci voted on patch set 7 V +1 07/29/26, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105630
-
Wouter Wolters uploaded patch set 8
V +107/30/26, 16:05 -
core-ci voted on patch set 8 V +1 07/30/26, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105702
-
Wouter Wolters uploaded patch set 9
V +107/30/26, 16:32 -
core-ci voted on patch set 9 V +1 07/30/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105704
-
Wouter Wolters marked it ready for review 07/30/26, 16:40
-
Oliver Klee voted on patch set 9 V +1 07/30/26, 17:28
-
Benni Mack uploaded patch set 10
V +108/12/26, 04:50 -
core-ci voted on patch set 10 V +1 08/12/26, 04:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106482
-
Benni Mack uploaded patch set 11
V +108/12/26, 06:16 -
core-ci voted on patch set 11 V +1 08/12/26, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106488
-
Oliver Klee voted on patch set 11 V +1 08/12/26, 08:05
-
Benni Mack commented on patch set 11 CR +1 V +1 08/12/26, 10:07
Reply
doneFormInlineAjaxControllerTest.php:61ReplycreateStubs() are merged now. -
Wouter Wolters uploaded patch set 12
CR +1V +108/12/26, 21:01 -
core-ci voted on patch set 12 V -1 08/12/26, 21:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106581
-
Oliver Klee voted on patch set 12 CR +1 V +1 08/12/26, 22:04
-
core-ci voted on patch set 12 V +1 08/12/26, 22:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106616
-
Simon Schaufelberger uploaded patch set 13
CR +1V +108/13/26, 09:35 -
core-ci voted on patch set 13 V +1 08/13/26, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106636
-
Benni Mack voted on patch set 13 CR +1 V +1 08/13/26, 13:09
-
Georg Ringer voted on patch set 13 CR +1 V +1 08/13/26, 13:50
-
Stefan Bürk commented on patch set 13 CR -1 08/13/26, 14:31
``` Declare the additional, unused argument as $_ in the two test methods whose data provider hands over more values than the method signature accepted. ``` missed that one - need to recheck, only from reading I'll assume that that is not the right solution. But in the lookthrough in the morining I could not find it ... which file/dataprovider ? (rechecking later). -
Wouter Wolters updated the commit message in patch set 14
CR +1V +108/13/26, 15:03 -
Wouter Wolters commented on patch set 14 08/13/26, 15:04
Reply
That has been split in to other patches. Updated the commit message -
core-ci voted on patch set 14 V +1 08/13/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106658
-
Stefan Bürk voted on patch set 14 CR +1 V +1 08/13/26, 15:18
-
Benni Mack voted on patch set 14 CR +2 V +2 08/13/26, 15:33
-
Benni Mack merged patch set 15 08/13/26, 15:33