Review 14.3 Merged

94881[BUGFIX] Merge size info into a single row in file info panel

Garvin Hicking CR +2 V +2 Easy +19 −1 updated 07/22/26, 11:27

Commit message

The generic field loop in `getPropertiesForTable()` lists all visible
TCA columns of `sys_file`, including "size" with its raw byte value.
Further down, an explicit "size" entry with a human-readable,
formatted value is added for file objects, resulting in the "size"
row being shown twice.

This patch now skips "size" in the generic loop for files, similar
to the existing "fileinfo" skip, since it is handled explicitly below.

Instead of discarding the raw byte value, the human-readable size is
combined into a single value, e.g. "103 KB (105,158 bytes)". A
new translatable "bytes" label with ICU plural form placeholders is
added, so the wording can be adjusted per language.

As a drive-by(e) the "crdate" column is also skipped now, as its
creation date information is already displayed on top of the
information block.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 07/22/26, 11:01

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/22/26, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105160

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 07/22/26, 11:27

  4. Garvin Hicking merged patch set 2 07/22/26, 11:27