Review main Merged

94882[TASK] Migrate low-level services to Schema API

Benni Mack CR +2 V +2 Hard +296 −13 updated 09/03/26, 11:20

Commit message

IconRegistry and DatabaseRowsUpdateWizard are the last
services in EXT:core that derive their table list and
"ctrl" settings from $GLOBALS['TCA']. Both now use the
Schema API: the registry reads "iconfile" from the schema
collection, the wizard takes the table list from the
collection and the delete field from the SoftDelete
capability.

The registry receives TcaSchemaFactory as an optional
dependency. The failsafe container used by the install
tool provides no schema factory, so no "tcarecords-*"
icons are registered there, also not after the late boot
that loads TCA. The install tool does not render record
icons, so this is not a functional loss. Within the full
container TCA icons are registered on the first call
after the schema has been loaded, as before.

Functional tests cover the TCA icon registration and the
update, soft delete and hard delete paths of the row
updater wizard.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1928

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 07/22/26, 11:17

  2. core-ci voted on patch set 1 V -1 07/22/26, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105162

  3. Benni Mack rebased onto patch set 2 V -1 07/22/26, 11:44

  1. core-ci voted on patch set 2 V -1 07/22/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105166

  2. Benni Mack uploaded patch set 3 V -1 08/06/26, 15:43

  3. core-ci voted on patch set 3 V +1 08/06/26, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106002

  4. Benni Mack updated the commit message in patch set 4 V +1 08/08/26, 15:15

  5. Benni Mack marked it ready for review 08/08/26, 15:15

  6. core-ci voted on patch set 4 V +1 08/08/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106188

  7. Benni Mack updated the commit message in patch set 5 V +1 08/10/26, 07:42

  8. core-ci voted on patch set 5 V -1 08/10/26, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106255

  9. Benni Mack rebased onto patch set 6 V -1 08/10/26, 07:50

  10. core-ci voted on patch set 6 V +1 08/10/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106256

  11. Stefan Bürk commented on patch set 6 08/13/26, 18:23

    IconRegistry.php:233

    Comment for the property sais: ``` ... therefore this dependency is optional and looked up lazily in initialize() ``` but to be honest, that's not what the code does. If the property is not set through the constructor it it will only check her if it is passed or not, otherwise tca icon registration is skipped. From the comment I would expect that it's retrieved here "again" lazily using GU::makeInstace(), but not that guard code. Either the comment in the property needs to change and possible adding some words here too - or changed. Also not tested - will the IconFactory be recreated once install tool elevate to extension loading ? (for the views loading them) For me that's clear enough. Where am I wrong ?
  12. Benni Mack commented on patch set 6 08/14/26, 15:06

    let's wait with this change until the conflicting RowUpdater Change is in

    IconRegistry.php:233 Reply

    I wonder how we should adapt this comment then? Also: The IconFactory won't be created in install tool, which I think is fine (no TCA icons in Install Tool).
  13. Benni Mack uploaded patch set 7 V +1 08/31/26, 22:01

  14. core-ci voted on patch set 7 V +1 08/31/26, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107447

  15. Benni Mack marked it ready for review 08/31/26, 22:10

  16. Benni Mack commented on patch set 7 09/01/26, 06:13

    Reply

    Done
  17. Stefan Bürk uploaded patch set 8 V +1 09/03/26, 08:37

  18. Stefan Bürk rebased onto patch set 9 09/03/26, 08:38

  19. core-ci voted on patch set 8 V +1 09/03/26, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107728

  20. core-ci voted on patch set 9 V +1 09/03/26, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107729

  21. Stefan Bürk commented on patch set 9 CR +1 V +1 09/03/26, 08:50

    IconRegistry.php:233 Reply

    I took the liverty to amend directly. This change already waited so long based on that thread (sorry for that!). Patchset 8 carries the follow-up, patchset 9 only and up2date rebase. Basically the docblock on `$tcaSchemaFactory` has been rewritten and now says *why* the argument is optional and the failsafe container has no instance of the TcaSchemaFactory and no icons are there. Further, I reduced the guard to a single guard instead of two and avoided unreachable code in the loop. I also adjusted the `ServiceProvider` comment to match the clear reality today. Tests are sligtly modified/enriched. Regarding my `InstallTool` question for the `IconFactory`, I'll checked it now and to answer my question myself: No. The install controllers get `IconFactory`, `IconRegisrty` and the failsafe `IconViewHelper` injected from the failsafe container. `BootService::makeCurrent()` only swaps the container gehind the `GeneralUtility` instance and already injected instances stay. Hope the changes are fine for you - and take my apology for the long hold on this.
  22. Oliver Klee voted on patch set 9 V +1 09/03/26, 08:54

  23. Benni Mack commented on patch set 9 09/03/26, 09:13

    thanks

    IconRegistry.php:233 Reply

    Done
  24. Georg Ringer voted on patch set 9 CR +2 V +2 09/03/26, 11:20

  25. Georg Ringer merged patch set 10 09/03/26, 11:20