Review main Merged

94884[BUGFIX] Allow non-scheme protocol URI as CSP site base

Benjamin Serfhos CR +2 V +2 Easy +11 −2 updated 07/23/26, 13:05

Commit message

Setting a protocol-relative base (or baseVariant) like this:

 `/en/@http-reporting?csp=report` (relative)
 `//ip12.anyhost.it:8443/en/@http-reporting?csp=report` (absolute)

was not resolved in the CSP PolicyProvider due to a boolean
comparison that would only match if both a scheme and a host
were not set.

This condition is now fixed to return a non-host-non-scheme
URI in both cases.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1322

  1. Benjamin Serfhos uploaded patch set 1 07/22/26, 12:18

  2. core-ci voted on patch set 1 V +1 07/22/26, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105172

  3. Benjamin Serfhos uploaded patch set 2 V +1 07/22/26, 12:27

  4. Benjamin Serfhos uploaded patch set 3 07/22/26, 12:28

  5. Benjamin Serfhos uploaded patch set 4 07/22/26, 12:35

  6. core-ci voted on patch set 2 V -1 07/22/26, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105173

  7. core-ci voted on patch set 3 V -1 07/22/26, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105174

  8. core-ci voted on patch set 4 V -1 07/22/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105175

  9. Benjamin Serfhos uploaded patch set 5 V -1 07/22/26, 12:52

  10. core-ci voted on patch set 5 V -1 07/22/26, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105178

  11. Benjamin Serfhos uploaded patch set 6 V -1 07/22/26, 13:19

  12. Benjamin Serfhos updated the commit message in patch set 7 07/22/26, 13:20

  13. core-ci voted on patch set 7 V -1 07/22/26, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105182

  14. core-ci voted on patch set 6 V -1 07/22/26, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105181

  15. Benjamin Serfhos uploaded patch set 8 V -1 07/22/26, 13:35

  16. core-ci voted on patch set 8 V +1 07/22/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105185

  17. Garvin Hicking voted on patch set 8 CR +1 V +1 07/23/26, 11:34

  18. Garvin Hicking updated the commit message in patch set 9 CR +1 V +1 07/23/26, 11:37

  19. Garvin Hicking voted on patch set 9 CR +1 V +1 07/23/26, 11:37

  20. core-ci voted on patch set 9 V +1 07/23/26, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105239

  21. Stefan Bürk voted on patch set 9 CR +2 V +2 07/23/26, 12:42

  22. Stefan Bürk merged patch set 10 07/23/26, 13:05