Review main Merged

94885[TASK] Streamline file upload handling in ext:impexp

Oliver Hader CR +2 V +2 Normal +165 −20 updated 07/23/26, 10:30

Commit message

The import module rendered the upload target folder into a
hidden form field and accepted it back from the request body.
This meant the upload target was client-influenced instead of
being fully server-controlled. In addition, the file extension
was checked only after the file had already been written.

This change pins the upload target to the server-resolved
import/export folder and stops routing it through the view.
Uploads whose extension is not "t3d" or "xml" are rejected
before the file is written to storage.

Note: None of the mentioned behavior is considered a security
vulnerability. The existing file-mount permission and
file-content consistency checks already prevented any impact,
this change only tightens the implementation further.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 78

  1. Oliver Hader uploaded patch set 1 07/22/26, 13:16

  2. core-ci voted on patch set 1 V +1 07/22/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105179

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/22/26, 18:25

  4. Oliver Klee voted on patch set 1 V +1 07/23/26, 06:59

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 07/23/26, 08:22

  6. Stefan Bürk voted on patch set 1 CR +1 V +1 07/23/26, 10:00

  7. Oliver Hader commented on patch set 1 CR +2 V +2 07/23/26, 10:19

    Thx folks! 😊
  8. Oliver Hader merged patch set 2 07/23/26, 10:30