Review main Merged

94887[TASK] Inject ConnectionPool, SiteFinder and Context in DI-ready classes

Benni Mack CR +2 V +2 Normal +106 −75 updated 07/23/26, 06:38

Commit message

Several services and controllers that already use constructor
injection still fetched ConnectionPool, SiteFinder or Context
via GeneralUtility::makeInstance() inline. Those dependencies
are now injected via the constructor as well.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 56

  1. Benni Mack uploaded patch set 1 07/22/26, 16:11

  2. core-ci voted on patch set 1 V +1 07/22/26, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105191

  3. Wouter Wolters voted on patch set 1 CR +1 07/22/26, 16:21

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 07/22/26, 18:21

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 07/23/26, 06:38

  6. Benjamin Franzke merged patch set 2 07/23/26, 06:38