Review main Merged

94890[TASK] Use new keyword for FlashMessage and report Status objects

Benni Mack CR +2 V +2 Hard +107 −202 updated 07/23/26, 08:53

Commit message

FlashMessage and the Status object of EXT:reports are plain
value objects. They are now instantiated via the "new" keyword
directly, as GeneralUtility::makeInstance() provides no benefit
for them.

Unit tests injecting FlashMessage mocks via
GeneralUtility::addInstance() are adjusted accordingly.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 50

Show 30 more files

Review log 56

  1. Benni Mack uploaded patch set 1 07/23/26, 07:24

  2. core-ci voted on patch set 1 V +1 07/23/26, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105214

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 07/23/26, 07:44

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 07/23/26, 08:26

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 07/23/26, 08:53

  6. Benjamin Franzke merged patch set 2 07/23/26, 08:53