Review 13.4 Merged

94897[TASK] Streamline file upload handling in ext:impexp

Oliver Hader CR +2 V +2 Hard +239 −20 updated 07/23/26, 10:30

Commit message

The import module rendered the upload target folder into a
hidden form field and accepted it back from the request body.
This meant the upload target was client-influenced instead of
being fully server-controlled. In addition, the file extension
was checked only after the file had already been written.

This change pins the upload target to the server-resolved
import/export folder and stops routing it through the view.
Uploads whose extension is not "t3d" or "xml" are rejected
before the file is written to storage.

Note: None of the mentioned behavior is considered a security
vulnerability. The existing file-mount permission and
file-content consistency checks already prevented any impact,
this change only tightens the implementation further.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 812

  1. Oliver Hader uploaded patch set 1 07/23/26, 09:05

  2. core-ci voted on patch set 1 V -1 07/23/26, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105228

  3. Oliver Hader uploaded patch set 2 V -1 07/23/26, 09:59

  4. Oliver Hader uploaded patch set 3 07/23/26, 10:04

  5. core-ci voted on patch set 2 V -1 07/23/26, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105231

  6. core-ci voted on patch set 3 V +1 07/23/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105233

  7. Oliver Hader voted on patch set 3 CR +2 V +2 07/23/26, 10:19

  8. Oliver Hader voted on patch set 3 CR -1 07/23/26, 10:21

  9. Oliver Hader uploaded patch set 4 CR -1 V +1 07/23/26, 10:23

  10. Oliver Hader voted on patch set 4 CR +2 V +2 07/23/26, 10:27

  11. core-ci voted on patch set 4 V +1 07/23/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105234

  12. Oliver Hader merged patch set 5 07/23/26, 10:30