Review 13.4 Merged

94906[BUGFIX] Allow non-scheme protocol URI as CSP site base

Stefan Bürk CR +2 V +2 Easy +11 −2 updated 07/23/26, 13:05

Commit message

Setting a protocol-relative base (or baseVariant) like this:

 `/en/@http-reporting?csp=report` (relative)
 `//ip12.anyhost.it:8443/en/@http-reporting?csp=report` (absolute)

was not resolved in the CSP PolicyProvider due to a boolean
comparison that would only match if both a scheme and a host
were not set.

This condition is now fixed to return a non-host-non-scheme
URI in both cases.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 07/23/26, 12:42

    Cherry Picked from branch 14.3.
  2. core-ci voted on patch set 1 V +1 07/23/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105249

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 07/23/26, 13:05

  4. Stefan Bürk merged patch set 2 07/23/26, 13:05